Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable SNS feature flag by default and update opt-in page #28282

Closed
yrliou opened this issue Feb 3, 2023 · 3 comments · Fixed by brave/brave-core#17034
Closed

Enable SNS feature flag by default and update opt-in page #28282

yrliou opened this issue Feb 3, 2023 · 3 comments · Fixed by brave/brave-core#17034

Comments

@yrliou
Copy link
Member

yrliou commented Feb 3, 2023

Once we switch to another provider that can support all RPC calls needed for SNS, we can enable the feature by default and update the opt-in page to specify the provider and link to its ToU and privacy policy.
cc @jamesmudgett

Screen Shot 2023-02-03 at 2 48 14 PM

Security and privacy review was already done in https://github.com/brave/security/issues/1099.
Main PRs for the feature: brave/brave-core#15617, brave/brave-core#15863
Wallet address resolution UI on Android was done in brave/brave-core#16423.

@yrliou yrliou added priority/P3 The next thing for us to work on. It'll ride the trains. feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop feature/web3/wallet/solana feature/web3/ddns labels Feb 3, 2023
@yrliou yrliou added this to Web3 Feb 3, 2023
@yrliou yrliou moved this to Backlog in Web3 Feb 3, 2023
@yrliou yrliou self-assigned this Feb 3, 2023
@yrliou yrliou moved this from Backlog to In Progress in Web3 Feb 3, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Web3 Feb 6, 2023
@brave-builds brave-builds added this to the 1.50.x - Nightly milestone Feb 6, 2023
@yrliou yrliou added the QA/Yes label Feb 8, 2023
@kjozwiak
Copy link
Member

The above requires 1.49.92 or higher for 1.49.x verification 👍

@srirambv
Copy link
Contributor

Verification passed on the following devices running 1.49.106 x64 build

  • Verified steps from brave/brave-core#17034
  • Verified SNS feature is enabled by default and set to Ask
  • Verified entering a .sol domain in omnibox shows SNS Interstitial page
  • Verified Disable sets SNS feature to Disabled
  • Verified Proceed with Syndica Server sets SNS feature to Enabled
  • Verified entering onybose.sol and ironpaw.sol in Send to field resolves the address
Oppo Reno 5 (Android 13) Samsung Tab A (Android 10)
28282-ARM.mp4
28282-Tab.mp4

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.49.108 Chromium: 110.0.5481.104 (Official Build) beta (64-bit)
Revision 46de4a7f41979e829b430bc1ee30ef483aa227ac-refs/branch-heads/5481_77@{#19}
OS Linux
  • Verified steps from brave/brave-core#17034
  • Verified SNS feature is enabled by default and set to Ask
  • Verified entering a .sol domain in omnibox shows SNS Interstitial page
  • Verified Disable sets SNS feature to Disabled
  • Verified Proceed with Syndica Server sets SNS feature to Enabled
  • Verified entering onybose.sol and ironpaw.sol in Send to field resolves the address
28282.mp4

Verification passed on

Brave 1.49.108 Chromium: 110.0.5481.104 (Official Build) beta (64-bit)
Revision 46de4a7f41979e829b430bc1ee30ef483aa227ac-refs/branch-heads/5481_77@{#19}
OS Windows 11 Version 22H2 (Build 22621.755)
  • Verified steps from brave/brave-core#17034
  • Verified SNS feature is enabled by default and set to Ask
  • Verified entering a .sol domain in omnibox shows SNS Interstitial page
  • Verified Disable sets SNS feature to Disabled
  • Verified Proceed with Syndica Server sets SNS feature to Enabled
  • Verified entering onybose.sol and ironpaw.sol in Send to field resolves the address
28282.mp4

Verification passed on

Brave 1.49.108 Chromium: 110.0.5481.104 (Official Build) beta (arm64)
Revision 46de4a7f41979e829b430bc1ee30ef483aa227ac-refs/branch-heads/5481_77@{#19}
OS macOS Version 13.0 (Build 22A380)
  • Verified steps from brave/brave-core#17034
  • Verified SNS feature is enabled by default and set to Ask
  • Verified entering a .sol domain in omnibox shows SNS Interstitial page
  • Verified Disable sets SNS feature to Disabled
  • Verified Proceed with Syndica Server sets SNS feature to Enabled
  • Verified entering onybose.sol and ironpaw.sol in Send to field resolves the address
28282.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants