Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors when opening Swap page and sometimes make it hard to select a token #28140

Closed
srirambv opened this issue Jan 30, 2023 · 1 comment
Closed
Labels
bug closed/invalid feature/web3/wallet/swap feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes

Comments

@srirambv
Copy link
Contributor

Description

Errors when opening Swap page and sometimes make it hard to select a token

Steps to Reproduce

  1. Load account with balance
  2. Go to the new swap page
  3. Check console, throws error about fetching balance
  4. Try to select a token from the token list, doesn't select on first click. Have to click multiple times to select it

Actual result:

image

7brave_wallet_page.bundle.js:155 Error querying balance: error=execution reverted asset= {"contractAddress":"0x8E3BCC334657560253B83f08331d85267316e08a","name":"Rubic","logo":"chrome://erc-token-images/brbc.png","isToken":true,"visible":true,"decimals":18,"symbol":"BRBC","coingeckoId":"","chainId":"0x1","coin":60}
7brave_wallet_page.bundle.js:155 Error querying balance: error=An internal error has occurred asset= {"contractAddress":"0xd55fce7cdab84d84f2ef3f99816d765a2a94a509","name":"Chain Games","logo":"chrome://erc-token-images/chain.png","isToken":true,"visible":true,"decimals":18,"symbol":"CHAIN","coingeckoId":"","chainId":"0x1","coin":60}
3brave_wallet_page.bundle.js:155 Error querying balance: error=execution reverted asset= {"contractAddress":"0x8E3BCC334657560253B83f08331d85267316e08a","name":"Rubic","logo":"chrome://erc-token-images/brbc.png","isToken":true,"visible":true,"decimals":18,"symbol":"BRBC","coingeckoId":"","chainId":"0x1","coin":60}
3brave_wallet_page.bundle.js:155 Error querying balance: error=An internal error has occurred asset= {"contractAddress":"0xd55fce7cdab84d84f2ef3f99816d765a2a94a509","name":"Chain Games","logo":"chrome://erc-token-images/chain.png","isToken":true,"visible":true,"decimals":18,"symbol":"CHAIN","coingeckoId":"","chainId":"0x1","coin":60}
2brave_wallet_page.bundle.js:155 Error querying balance: error=execution reverted asset= {"contractAddress":"0x8E3BCC334657560253B83f08331d85267316e08a","name":"Rubic","logo":"chrome://erc-token-images/brbc.png","isToken":true,"visible":true,"decimals":18,"symbol":"BRBC","coingeckoId":"","chainId":"0x1","coin":60}
2brave_wallet_page.bundle.js:155 Error querying balance: error=An internal error has occurred asset= {"contractAddress":"0xd55fce7cdab84d84f2ef3f99816d765a2a94a509","name":"Chain Games","logo":"chrome://erc-token-images/chain.png","isToken":true,"visible":true,"decimals":18,"symbol":"CHAIN","coingeckoId":"","chainId":"0x1","coin":60}
13brave_wallet_page.bundle.js:155 Error querying balance: error=execution reverted asset= {"contractAddress":"0x8E3BCC334657560253B83f08331d85267316e08a","name":"Rubic","logo":"chrome://erc-token-images/brbc.png","isToken":true,"visible":true,"decimals":18,"symbol":"BRBC","coingeckoId":"","chainId":"0x1","coin":60}
brave_wallet_page.bundle.js:9502 Uncaught (in promise) Error: Failed to fetch price: eth-wusdt
    at brave_wallet_page.bundle.js:9502:849
    at async brave_wallet_page.bundle.js:155:66494
brave_wallet_page.bundle.js:9502 Uncaught (in promise) Error: Failed to fetch price: eth-wusdt
    at brave_wallet_page.bundle.js:9502:849
    at async brave_wallet_page.bundle.js:155:66528
brave_wallet_page.bundle.js:155 Error querying balance: error=An internal error has occurred asset= {"contractAddress":"0xd55fce7cdab84d84f2ef3f99816d765a2a94a509","name":"Chain Games","logo":"chrome://erc-token-images/chain.png","isToken":true,"visible":true,"decimals":18,"symbol":"CHAIN","coingeckoId":"","chainId":"0x1","coin":60}
brave_wallet_page.bundle.js:155 Error querying balance: error=execution reverted asset= {"contractAddress":"0x8E3BCC334657560253B83f08331d85267316e08a","name":"Rubic","logo":"chrome://erc-token-images/brbc.png","isToken":true,"visible":true,"decimals":18,"symbol":"BRBC","coingeckoId":"","chainId":"0x1","coin":60}
brave_wallet_page.bundle.js:9502 Uncaught (in promise) Error: Failed to fetch price: eth-wusdt
    at brave_wallet_page.bundle.js:9502:849
    at async brave_wallet_page.bundle.js:155:66494
brave_wallet_page.bundle.js:9502 Uncaught (in promise) Error: Failed to fetch price: eth-wusdt
    at brave_wallet_page.bundle.js:9502:849
    at async brave_wallet_page.bundle.js:155:66528
8brave_wallet_page.bundle.js:155 Error querying balance: error=An internal error has occurred asset= {"contractAddress":"0xd55fce7cdab84d84f2ef3f99816d765a2a94a509","name":"Chain Games","logo":"chrome://erc-token-images/chain.png","isToken":true,"visible":true,"decimals":18,"symbol":"CHAIN","coingeckoId":"","chainId":"0x1","coin":60}
brave_wallet_page.bundle.js:9502 Uncaught (in promise) Error: Failed to fetch price: eth-wusdt
    at brave_wallet_page.bundle.js:9502:849
    at async brave_wallet_page.bundle.js:155:66528
3brave_wallet_page.bundle.js:155 Error querying balance: error=An internal error has occurred asset= {"contractAddress":"0xd55fce7cdab84d84f2ef3f99816d765a2a94a509","name":"Chain Games","logo":"chrome://erc-token-images/chain.png","isToken":true,"visible":true,"decimals":18,"symbol":"CHAIN","coingeckoId":"","chainId":"0x1","coin":60}
brave_wallet_page.bundle.js:155 Error querying balance: error=execution reverted asset= {"contractAddress":"0x8E3BCC334657560253B83f08331d85267316e08a","name":"Rubic","logo":"chrome://erc-token-images/brbc.png","isToken":true,"visible":true,"decimals":18,"symbol":"BRBC","coingeckoId":"","chainId":"0x1","coin":60}
3brave_wallet_page.bundle.js:155 Error querying balance: error=An internal error has occurred asset= {"contractAddress":"0xd55fce7cdab84d84f2ef3f99816d765a2a94a509","name":"Chain Games","logo":"chrome://erc-token-images/chain.png","isToken":true,"visible":true,"decimals":18,"symbol":"CHAIN","coingeckoId":"","chainId":"0x1","coin":60}
brave_wallet_page.bundle.js:9502 Uncaught (in promise) Error: Failed to fetch price: eth-wusdt
    at brave_wallet_page.bundle.js:9502:849
    at async brave_wallet_page.bundle.js:155:66494
2brave_wallet_page.bundle.js:9502 Uncaught (in promise) Error: Failed to fetch price: eth-wusdt
    at brave_wallet_page.bundle.js:9502:849
    at async brave_wallet_page.bundle.js:155:66528
brave_wallet_page.bundle.js:9502 Uncaught (in promise) Error: Failed to fetch price: eth-wusdt
    at brave_wallet_page.bundle.js:9502:849
    at async brave_wallet_page.bundle.js:155:66494
brave_wallet_page.bundle.js:9502 Uncaught (in promise) Error: Failed to fetch price: eth-wusdt
    at brave_wallet_page.bundle.js:9502:849
    at async brave_wallet_page.bundle.js:155:66528
brave_wallet_page.bundle.js:155 Error querying balance: error=execution reverted asset= {"contractAddress":"0x8E3BCC334657560253B83f08331d85267316e08a","name":"Rubic","logo":"chrome://erc-token-images/brbc.png","isToken":true,"visible":true,"decimals":18,"symbol":"BRBC","coingeckoId":"","chainId":"0x1","coin":60}
brave_wallet_page.bundle.js:155 Error querying balance: error=An internal error has occurred asset= {"contractAddress":"0xd55fce7cdab84d84f2ef3f99816d765a2a94a509","name":"Chain Games","logo":"chrome://erc-token-images/chain.png","isToken":true,"visible":true,"decimals":18,"symbol":"CHAIN","coingeckoId":"","chainId":"0x1","coin":60}

Expected result:

No errors about fetching balance and able to select token in one click

Reproduces how often:

Easy and very often

Brave version (brave://version info)

Brave 1.48.141 Chromium: 109.0.5414.119 (Official Build) beta (64-bit)
Revision 772095164c7d5d4e73160f858efed3b5e87eca83-refs/branch-heads/5414@{#1458}
OS Windows 11 Version 22H2 (Build 22621.755)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @onyb @Douglashdaniel @josheleonard

@srirambv srirambv added bug QA/Yes feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop labels Jan 30, 2023
@srirambv srirambv added this to Web3 Jan 30, 2023
@jamesmudgett jamesmudgett added the priority/P3 The next thing for us to work on. It'll ride the trains. label Feb 3, 2023
@jamesmudgett jamesmudgett moved this to Backlog in Web3 Feb 3, 2023
@Douglashdaniel
Copy link

Is no longer an issue after we moved Swap V2 into brave-core. Closing as Invalid

@github-project-automation github-project-automation bot moved this from Backlog to Done in Web3 Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug closed/invalid feature/web3/wallet/swap feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes
Projects
Archived in project
Development

No branches or pull requests

4 participants