Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting Swap input value retains the swap quotes #28137

Closed
srirambv opened this issue Jan 30, 2023 · 2 comments · Fixed by brave/brave-core#17239
Closed

Deleting Swap input value retains the swap quotes #28137

srirambv opened this issue Jan 30, 2023 · 2 comments · Fixed by brave/brave-core#17239
Labels
bug feature/web3/wallet/swap feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude

Comments

@srirambv
Copy link
Contributor

Description

Deleting Swap input value retains the swap quotes

Steps to Reproduce

  1. Select a token to swap
  2. Select a value or select pre-set values
  3. Wait for the swap quote to refresh
  4. Delete the input value of Swap token, quote refreshes and is retained

Actual result:

Swap.Quotes.mp4

Expected result:

Not sure maybe remove quotes

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.48.141 Chromium: 109.0.5414.119 (Official Build) beta (64-bit)
Revision 772095164c7d5d4e73160f858efed3b5e87eca83-refs/branch-heads/5414@{#1458}
OS Windows 11 Version 22H2 (Build 22621.1105)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @onyb @jamesmudgett @minkyeongshin

@kjozwiak
Copy link
Member

@srirambv as per the discussion via https://bravesoftware.slack.com/archives/CHGKGMHDJ/p1676524126357019, please create a follow up to this one. Labelling as QA/No and release-notes/exclude as it's still reproducible/not addressed by brave/brave-core#17239.

@srirambv
Copy link
Contributor Author

Logged follow up issue #28618

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/web3/wallet/swap feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants