Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] panel and brave://rewards have different UI in the "Logged out" state - follow up to 20450 #28096

Closed
LaurenWags opened this issue Jan 27, 2023 · 3 comments · Fixed by brave/brave-core#17087
Assignees
Labels
Android 8 - Test/Verification Checking on an older Android device to make sure everything is working as expected feature/rewards OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Test-All-Device-Types QA/Yes release-notes/exclude

Comments

@LaurenWags
Copy link
Member

Description

Follow up to #20450

The panel and brave://rewards page have different UI in "Logged out" state on Android. These two areas match on desktop. Android brave://rewards page matches desktop behavior. The panel is what is inconsistent.

The panel does not show the blue box which says "Log in to [custodian] to see your balance", the panel shows 0.00 balance instead. This is inconsistent with both the brave://rewards page on Android as well as the Desktop implementation.

Steps to reproduce

  1. Clean install
  2. Navigate QA Preferences
  3. Enable staging environment, relaunch as necessary
  4. Enable Rewards
  5. Select Verify Wallet and login with custodial account
  6. Confirm balance is shown in UI
  7. On custodial site, revoke access to Brave Browser (where applicable)
  8. Compare UI on panel and rewards page.

Actual result

Panel is missing the blue box and shows 0.00 balance instead:

1-a

Expected result

should match android brave://rewards page and desktop panel & brave://rewards page:

Android brave://rewards Desktop Panel Desktop brave://rewards
1-c 2-a 2-c

Issue reproduces how often

easily

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? n/a
  • Can you reproduce this issue with the current Play Store Beta version? yes
  • Can you reproduce this issue with the current Play Store Nightly version?yes

Device details

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Brave version

1.48.141

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

cc @Miyayes @deeppandya

@LaurenWags LaurenWags added feature/rewards QA/Yes release-notes/exclude OS/Android Fixes related to Android browser functionality labels Jan 27, 2023
@Miyayes Miyayes added the priority/P2 A bad problem. We might uplift this to the next planned release. label Jan 27, 2023
@Miyayes
Copy link
Collaborator

Miyayes commented Jan 27, 2023

@kjozwiak
Copy link
Member

The above requires 1.49.91 or higher for 1.49.x verification 👍

@kjozwiak kjozwiak added QA/Test-All-Device-Types Android 8 - Test/Verification Checking on an older Android device to make sure everything is working as expected labels Feb 10, 2023
@GeetaSarvadnya GeetaSarvadnya added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Mar 3, 2023
@GeetaSarvadnya
Copy link

Verification PASSED on Samsung Galaxy version 12 running Bravemonoarm64.apk_1.49.116

  • Verified the STR from the description and ensured that the "Logged out" UI is shown corectly on brave://rewards settings page, BR panel and pubs panel.
Example Example Example
Screenshot_20230303-135508_Brave - Beta Screenshot_20230303-135521_Brave - Beta Screenshot_20230303-135538_Brave - Beta

@GeetaSarvadnya GeetaSarvadnya added QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android 8 - Test/Verification Checking on an older Android device to make sure everything is working as expected feature/rewards OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Test-All-Device-Types QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants