Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account and network changes when navigating between Buy/Deposit options #28040

Closed
srirambv opened this issue Jan 25, 2023 · 1 comment · Fixed by brave/brave-core#16864
Closed
Assignees
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include

Comments

@srirambv
Copy link
Contributor

Description

Account and network changes when navigating between Buy/Deposit options

Steps to Reproduce

  1. Switch to Market tab
  2. Select UNI token
  3. Select Buy
  4. Loads UNI on Ethereum Network
  5. Check Account on widget changes to Ethereum Account
  6. Go back to UNI Token
  7. Select Deposit
  8. Loads UNI on Solana Mainnet
  9. Check account on widget changes to Solana Account

Actual result:

Account.Change.mp4

Expected result:

Shouldn't switch network/Accounts

Reproduces how often:

Easy

Brave version (brave://version info)

All

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @josheleonard @Douglashdaniel @HEagle18

@srirambv srirambv added this to Web3 Jan 25, 2023
@Douglashdaniel Douglashdaniel self-assigned this Jan 25, 2023
@Douglashdaniel Douglashdaniel moved this to In Progress in Web3 Jan 25, 2023
@Douglashdaniel Douglashdaniel moved this from In Progress to In Review in Web3 Jan 25, 2023
@Douglashdaniel Douglashdaniel added the front-end-change This task is a front end task and doesn't need any C++ changes label Jan 25, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Jan 25, 2023
@brave-builds brave-builds added this to the 1.49.x - Nightly milestone Jan 25, 2023
@srirambv
Copy link
Contributor Author

srirambv commented Mar 3, 2023

Verification passed on

Brave 1.49.118 Chromium: 111.0.5563.50 (Official Build) (64-bit)
Revision 39f3dfc5023fe60997adc4f6cf5439cfa3e6968a-refs/branch-heads/5563@{#903}
OS Windows 11 Version 22H2 (Build 22621.755)
  • Verified steps from issue description and brave/brave-core#16864
  • Verified set network is retained when a different token is selected in Buy/Deposit screen
28040.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants