Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to Hide NFTs with the same contract address #27906

Closed
Douglashdaniel opened this issue Jan 19, 2023 · 1 comment · Fixed by brave/brave-core#16750
Closed

Unable to Hide NFTs with the same contract address #27906

Douglashdaniel opened this issue Jan 19, 2023 · 1 comment · Fixed by brave/brave-core#16750
Assignees
@Douglashdaniel
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes regression release-notes/include
Milestone
1.49.x - Release

Comments

@Douglashdaniel
Copy link

Douglashdaniel commented Jan 19, 2023 •
edited
Loading

Description

If you try to hide an NFT with the same contract address it will either uncheck all or not check at all

Steps to Reproduce

  1. Add 2 NFT's with the same contract address
  2. Open the Edit visible assets modal
  3. Try to hide one of them, it will either uncheck all or not check at all.

Actual result:

Screen.Recording.2023-01-19.at.11.35.31.AM.mov

Expected result:

You should be able to hide individual NFT's with the same contract address.

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:
@Douglashdaniel Douglashdaniel added bug QA/Yes release-notes/exclude regression feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Jan 19, 2023
@Douglashdaniel Douglashdaniel self-assigned this Jan 19, 2023
@Douglashdaniel Douglashdaniel moved this to In Progress in Web3 Jan 19, 2023
@Douglashdaniel Douglashdaniel mentioned this issue Jan 19, 2023
Merged
25 tasks
@Douglashdaniel Douglashdaniel moved this from In Progress to In Review in Web3 Jan 19, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Jan 19, 2023
@brave-builds brave-builds added this to the 1.49.x - Nightly milestone Jan 19, 2023
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.49.108 Chromium: 110.0.5481.104 (Official Build) beta (64-bit)
Revision 46de4a7f41979e829b430bc1ee30ef483aa227ac-refs/branch-heads/5481_77@{#19}
OS Linux
  • Verified steps from brave/brave-core#16750
  • Verified able to hide and show NFT's from the same contract address
27906.mp4

Verification passed on

Brave 1.49.108 Chromium: 110.0.5481.104 (Official Build) beta (64-bit)
Revision 46de4a7f41979e829b430bc1ee30ef483aa227ac-refs/branch-heads/5481_77@{#19}
OS Windows 11 Version 22H2 (Build 22621.755)
  • Verified steps from brave/brave-core#16750
  • Verified able to hide and show NFT's from the same contract address
27906.mp4

Verification passed on

Brave 1.49.108 Chromium: 110.0.5481.104 (Official Build) beta (arm64)
Revision 46de4a7f41979e829b430bc1ee30ef483aa227ac-refs/branch-heads/5481_77@{#19}
OS macOS Version 13.0 (Build 22A380)
  • Verified steps from brave/brave-core#16750
  • Verified able to hide and show NFT's from the same contract address
27906.mov

@LaurenWags LaurenWags mentioned this issue Mar 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes regression release-notes/include
Projects
Web3
Archived in project
Milestone
1.49.x - Release
Development

Successfully merging a pull request may close this issue.

fix(wallet): Hiding NFTs with same Contracts brave/brave-core
3 participants
@srirambv @Douglashdaniel @brave-builds