-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to go back from wallet view using back button [Android 13] #27787
Comments
Good catch. Definitely Android 13 issue as I haven't seen it happen on my Android 12 devices |
@Uni-verse it's a bit different on the
Example of the issue re: swiping not working: screen-20230114-014718.mp4 |
+1 this, encountered on Samsung Fold3 on Android v13. 1.47.175 Chromium: 109.0.5414.87 (Official Build) (64-bit) Also tested the following journeys, all with the same result of being unable to go "back" to browsing from Wallet UX:
If the user has navigated from wallet/Portfolio => wallet/Accounts; the OS back button should navigate the user back to wallet/Portfolio as that screen and UI were where the user was in the journey, prior to being in Wallet/Accounts view. If the user is in Portfolio view and uses the OS back button; navigate the user to the browser tab they were active in prior to navigating to brave://wallet/portfolio |
Workaround for now is to background the app and relaunch which closes the wallet view. |
Same community issue report: https://community.brave.com/t/android-how-to-switch-back-to-browser/464823 |
Solution: We need to use registerOnBackInvokedCallback to listen and finish the activity. |
The above requires |
Moving this into The above can be verified with |
Verification PASSED on
|
Description
After selecting wallet from the hamburger menu, user is unable to go back to NTP. This is the case in all wallet views. User has to background/foreground or relaunch.
I have a Samsung Tablet with Android version 12 and it doesn't reproduce.
Steps to reproduce
Actual result
Does not go back to NTP
wallet_view_no_return2.mp4
Expected result
Should go back to NTP
Issue reproduces how often
Easily
Version/Channel Information:
Device details
Brave version
1.46.x, 1.47.x, 1.48.x, 1.49.x
Website problems only
Additional information
The text was updated successfully, but these errors were encountered: