Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot import extensions from Chrome #27770

Closed
spylogsster opened this issue Jan 12, 2023 · 5 comments · Fixed by brave/brave-core#16638
Closed

Cannot import extensions from Chrome #27770

spylogsster opened this issue Jan 12, 2023 · 5 comments · Fixed by brave/brave-core#16638

Comments

@spylogsster
Copy link

spylogsster commented Jan 12, 2023

Description

Steps to Reproduce

  1. Install extensions to chrome
  2. Import Chrome profile to Brave

Actual result:

Extensions not imported

Expected result:

Extensions imported

Reproduces how often:

100%

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Test Plan:

  • Install latest Chrome (for win I use 109.0.5414.75 (Official Build) (64-bit)) and install an extension from web store, I use jfbnmfgkohlfclfnplnlenbalpppohkm for testing
  • Check c:\Users\[username]\AppData\Local\Google\Chrome\User Data\Default\Secure Preferences file, it should have one line without extensions info.
  • Try to import from Chrome profile
  • Make sure installed extension imported to Brave.
  • Additionally check extensions can be imported from Chrome and others Chromium based browsers who keeps information inside Secure Preferences, I checked with Yandex.
@spylogsster
Copy link
Author

cc @rebron

@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jan 12, 2023
@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Feb 13, 2023
@stephendonner
Copy link

stephendonner commented Feb 13, 2023

Verified PASSED using

Brave 1.49.96 Chromium: 110.0.5481.77 (Official Build) beta (x86_64)
Revision 65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS macOS Version 11.7.3 (Build 20G1116)

and

Google Chrome 110.0.5481.77 (Official Build) (x86_64)
Revision 65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS macOS Version 11.7.3 (Build 20G1116)
Yandex 108.0.5359.978 (x86_64)
Revision 432404deeb40c2c124c902f2a8193a70e893b825
OS macOS Version 11.7.3 (Build 20G1116)

Case 1: Import extensions from Google Chrome - PASSED (*)

Steps:

Prerequisite: latest Chrome release browser, populated with at least 2 extensions in a profile

  1. installed 1.49.96
  2. launched Brave
  3. clicked on Skip
  4. clicked on Chrome
  5. clicked on Import
  6. clicked on Finish
  7. opened brave://extensions

* Google Docs Offline and Show YouTube Dislikes were both missing from the imported list

example example example example example example example
Screen Shot 2023-02-13 at 1 40 04 PM Screen Shot 2023-02-13 at 1 43 55 PM Screen Shot 2023-02-13 at 1 44 02 PM Screen Shot 2023-02-13 at 1 44 27 PM Screen Shot 2023-02-13 at 1 44 34 PM Screen Shot 2023-02-13 at 1 44 44 PM Screen Shot 2023-02-13 at 1 54 35 PM

Case 2: Import extensions from Yandex - PASSED (*)

Steps:

Prerequisite: latest Yandex release browser, populated with at least 2 extensions in a profile

  1. installed 1.49.96
  2. launched Brave
  3. clicked on Skip
  4. clicked on Yandex
  5. clicked on Import
  6. clicked on Finish
  7. opened brave://extensions

* 1Password was missing from the imported list

example example example example example example example
Screen Shot 2023-02-13 at 1 58 40 PM Screen Shot 2023-02-13 at 2 00 51 PM Screen Shot 2023-02-13 at 2 00 56 PM Screen Shot 2023-02-13 at 2 01 03 PM Screen Shot 2023-02-13 at 2 01 07 PM Screen Shot 2023-02-13 at 2 01 10 PM Screen Shot 2023-02-13 at 2 01 21 PM

NOTE: Will investigate the import failures, file, and circle back.

@stephendonner stephendonner added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Feb 13, 2023
@MadhaviSeelam
Copy link

MadhaviSeelam commented Feb 21, 2023

Verification PASSED using

Brave | 1.49.106 Chromium: 110.0.5481.104 (Official Build) beta (64-bit)
-- | --
Revision | 46de4a7f41979e829b430bc1ee30ef483aa227ac-refs/branch-heads/5481_77@{#19}
OS | Windows 11 Version 21H2 (Build 22000.1574)

Pre - requisites: Populate Chrome release browser and Vivaldi browser with at least 2 extensions in a profile

Chrome:
image


Vivaldi: Imported Roblox extension (jfbnmfgkohlfclfnplnlenbalpppohkm)and 1 Password confirmed the extensions are shown Secure Preferences
image

Case 1: Import extensions from Google Chrome via brave://welcome - PASSED

  1. installed 1.49.106
  2. launched Brave
  3. clicked on Skip
  4. clicked on Chrome
  5. clicked on Import
  6. select Chrome Person 1
  7. clicked Import profiles
  8. clicked on Finish
  9. opened brave://extensions

Confirmed all extensions imported except for Google Docs Offline

step 4 - 5 step 6-7 step 8 step 9
image image image image

Case 2: Import extensions from Vivaldi via brave://settings/importData - PASSED

  1. New profile
  2. launched Brave
  3. clicked on Skip >> Skip >>Finish
  4. open brave://settings/importData`
  5. select Vivaldi Person 1
  6. click Import
  7. click Done
  8. opened brave://extensions

Confirmed both extensions are imported

step 5-6 step 7 step 8
image image image

@MadhaviSeelam
Copy link

@stephendonner - Show YouTube Dislikes extension was successfully imported in Win 11 x64. However Google Docs Offline was not imported as it was installed by default and it is expected behavior.
cc: @spylogsster.

@MadhaviSeelam MadhaviSeelam added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Mar 1, 2023
@MadhaviSeelam
Copy link

MadhaviSeelam commented Mar 1, 2023

Verification PASSED using

Brave	1.49.116 Chromium: 110.0.5481.177 (Official Build) beta (64-bit) 
Revision	f34f7ab2d4ca4ad498ef42aeba4f4eb2c1392d63-refs/branch-heads/5481@{#1239}
OS	Linux

Pre-requisites: Populate Chrome release browser and Vivaldi browser with at least 2 extensions in a profile

Chrome:
image

Vivaldi:
image

Case 1: Import extensions from Google Chrome via brave://welcome - PASSED

  • installed 1.49.116
  • launched Brave
  • clicked on Set Brave as default browser
  • clicked on Chrome
  • clicked on Import
  • clicked on Finish
  • opened brave://extensions
  • Confirmed all extensions imported

    Note: Google Docs Offline will not be imported as it was installed by default and it's expected behavior

    step 3 step 4 - 5 step 6 result
    image image image image

    Case 2: Import extensions from Vivaldi via brave://settings/importData - PASSED

    1. New profile
    2. launched Brave
    3. clicked on Skip >> Skip >>Finish
    4. open brave://settings/importData`
    5. select Vivaldi Person 1
    6. click Import
    7. click Done
    8. opened brave://extensions

    Confirmed both extensions are imported

    step 5-6 step 7 step 8
    image image image

    @MadhaviSeelam MadhaviSeelam added QA Pass-Linux and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 1, 2023
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging a pull request may close this issue.

    5 participants