Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Uphold equities promo card #27759

Closed
Miyayes opened this issue Jan 11, 2023 · 2 comments · Fixed by brave/brave-core#16622
Closed

Remove Uphold equities promo card #27759

Miyayes opened this issue Jan 11, 2023 · 2 comments · Fixed by brave/brave-core#16622
Assignees
@mkarolin
Labels
feature/rewards/Uphold feature/rewards OS/Desktop priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
1.47.x - Release #4

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Jan 11, 2023 •
edited by mkarolin
Loading

Description

Remove: https://github.com/brave/brave-core/blob/master/components/brave_rewards/resources/page/lib/promotions.ts#L86

Was implemented as part of: https://github.com/brave/brave-core/pull/6951/files (#12276).

Question: Can we also check under what conditions this promo card even appears?

Test Plan:

See #12276 (comment) and ensure that the card is not shown in the countries noted in the comment.
@Miyayes Miyayes added feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. OS/Desktop feature/rewards/Uphold labels Jan 11, 2023
@mkarolin mkarolin mentioned this issue Jan 11, 2023
Merged
25 tasks
@mkarolin mkarolin added this to the 1.49.x - Nightly milestone Jan 12, 2023
This was referenced Jan 12, 2023
Merged
Merged
@kjozwiak
Copy link
Member

The above requires 1.47.176 or higher for 1.47.x verification 👍

@MadhaviSeelam MadhaviSeelam added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jan 19, 2023
@MadhaviSeelam
Copy link

MadhaviSeelam commented Jan 19, 2023 •
edited
Loading

Verification PASSED using

Brave | 1.47.177 Chromium: 109.0.5414.87 (Official Build) (64-bit)
-- | --
Revision | 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS | Windows 11 Version 21H2 (Build 22000.1455)
  • Install 1.47.177
  • launch Brave
  • changed locales in Windows settings from the list to test
  • enabled rewards
  • opened brave://rewards

Confirmed that the Uphold Equities Card banner/promo not displayed.

Cayman Islands

settings 1.47.171(before fix) 1.47.177(after fix)
image image image

Brazil

settings 1.47.171(before fix) 1.47.177(after fix)
image image image

Confirmed Uphold Equities Card banner/promo not displayed for countries (eg.US and France) that never displayed them.

US

settings 1.47.171(before fix) 1.47.177 (after fix)
image image image

France

settings 1.47.171 1.47.177
image image image

@MadhaviSeelam MadhaviSeelam added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkarolin mkarolin

Labels
feature/rewards/Uphold feature/rewards OS/Desktop priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.47.x - Release #4
Development

Successfully merging a pull request may close this issue.

[Rewards] Removes uphold equity promo card. brave/brave-core
5 participants
@kjozwiak @Miyayes @mkarolin @brave-builds @MadhaviSeelam