Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

com.apple.Reading List namespace shows up from Safari import #27738

Closed
stephendonner opened this issue Jan 11, 2023 · 1 comment · Fixed by brave/brave-core#16784
Closed

com.apple.Reading List namespace shows up from Safari import #27738

stephendonner opened this issue Jan 11, 2023 · 1 comment · Fixed by brave/brave-core#16784

Comments

@stephendonner
Copy link

stephendonner commented Jan 11, 2023

Description

com.apple.Reading List namespace shows up from Safari import

Steps to Reproduce

Prerequisite:

  • Seed Safari with both bookmarks and at least one Reading List item
Screen Shot 2023-01-10 at 6 37 27 PM
  1. install 1.48.119
  2. launch Brave
  3. clip Skip on the 1st page of the brave://welcome screen onboarding
  4. on the next page, choose Safari
  5. click on Import
  6. click Finish
  7. open brave://bookmarks
  8. look at Imported from Safari
  9. compare the imported Reading List entry to the one you added in Safari

Actual result:

Shows the namespace com.apple.Reading List as the containing folder name

Screen Shot 2023-01-10 at 6 34 21 PM

Expected result:

It should appear as Reading List, as it does in Microsoft Edge's import:

Screen Shot 2023-01-10 at 6 36 06 PM

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.48.119 Chromium: 109.0.5414.80 (Official Build) beta (x86_64)
Revision 0f69b168d36a06cace4365e9f029fa987afa5633-refs/branch-heads/5414@{#1178}
OS macOS Version 11.7.2 (Build 20G1020)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Probably

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

/cc @nullhook @rebron @brave/qa-team @spylogsster

@stephendonner
Copy link
Author

Verified PASSED using

Brave 1.49.88 Chromium: 110.0.5481.77 (Official Build) beta (x86_64)
Revision 65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS macOS Version 11.7.3 (Build 20G1116)

Steps:

  1. installed 1.49.88
  2. launched Brave
  3. clipped Skip on the 1st page of the brave://welcome screen onboarding
  4. on the next page, chose Safari
  5. clicked on Import
  6. clicked Finish
  7. opened brave://bookmarks
  8. looked at Imported from Safari
  9. compared the imported Reading List entry to the one you added in Safari

Confirmed it now reads Reading LIst

example example example example
Screen Shot 2023-02-06 at 11 04 27 PM Screen Shot 2023-02-06 at 11 04 30 PM Screen Shot 2023-02-06 at 11 04 35 PM Screen Shot 2023-02-06 at 11 05 18 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants