Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Mint Address for Solana NFT #27664

Closed
nuo-xu opened this issue Jan 5, 2023 · 1 comment · Fixed by brave/brave-core#16730
Closed

Use Mint Address for Solana NFT #27664

nuo-xu opened this issue Jan 5, 2023 · 1 comment · Fixed by brave/brave-core#16730
Assignees
@josheleonard
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.49.x - Release

Comments

@nuo-xu
Copy link

nuo-xu commented Jan 5, 2023 •
edited
Loading

  1. Change Token Address to Mint Address in add custom token screen when user selects a Solana network
  2. Change Token ID to Mint Address in Solana NFT detail screen. since (1) user wont input token id when they add custom solana NFT and (2) there is no token id coming from Solana NFT metadata.

iOS screenshots
simulator_screenshot_09DC352D-24ED-4373-A29E-C8535CE4C615
simulator_screenshot_C73EB387-B020-4AC7-82BD-A2B498297BAD
@nuo-xu nuo-xu added feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop labels Jan 5, 2023
@nuo-xu nuo-xu added this to Web3 Jan 5, 2023
This was referenced Jan 5, 2023
Closed
Closed
@jamesmudgett jamesmudgett moved this to Backlog in Web3 Jan 6, 2023
@jamesmudgett jamesmudgett added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jan 6, 2023
@josheleonard josheleonard self-assigned this Jan 18, 2023
@josheleonard josheleonard moved this from Backlog to In Progress in Web3 Jan 18, 2023
@josheleonard josheleonard mentioned this issue Jan 18, 2023
Merged
25 tasks
@josheleonard josheleonard moved this from In Progress to In Review in Web3 Jan 18, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Jan 20, 2023
@brave-builds brave-builds added this to the 1.49.x - Nightly milestone Jan 20, 2023
@srirambv
Copy link
Contributor

srirambv commented Mar 1, 2023

Verification passed on

Brave 1.49.108 Chromium: 110.0.5481.104 (Official Build) beta (64-bit)
Revision 46de4a7f41979e829b430bc1ee30ef483aa227ac-refs/branch-heads/5481_77@{#19}
OS Windows 11 Version 22H2 (Build 22621.755)
  • Verified steps from brave/brave-core#16730
  • Verified selecting Solana Network from network selector updates Token Address to Mint Address
  • Verified the change happens for both custom tokens and NFT's
Ethereum Token Solana Token
image image
Ethereum NFT Solana NFT
image image

@LaurenWags LaurenWags mentioned this issue Mar 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josheleonard josheleonard

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.49.x - Release
Development

Successfully merging a pull request may close this issue.

fix: use mint address for SOL token & NFT form brave/brave-core
5 participants
@jamesmudgett @nuo-xu @srirambv @josheleonard @brave-builds