Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display reason for disabled "Add" button when attempting to add an invalid custom token #27636

Closed
josheleonard opened this issue Jan 4, 2023 · 1 comment · Fixed by brave/brave-core#16550
Closed

Display reason for disabled "Add" button when attempting to add an invalid custom token #27636

josheleonard opened this issue Jan 4, 2023 · 1 comment · Fixed by brave/brave-core#16550
Assignees
@josheleonard
Labels
design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.49.x - Release

Comments

@josheleonard
Copy link

Description

Users should be informed as to why the form submission button ("Add") is disabled during the process of adding a custom token visible asset. Any validation error should be displayed to the user so that it is clear why the submit button is disabled.

Steps to Reproduce

  1. Click the Add Visible Assets button on the wallet portfolio screen
  2. click add custom asset
  3. leave all form fields blank
  4. Attempt to click the "Add" button

Actual result:

Nothing is displayed to the user as to why the button is disabled.

Expected result:

UI is displayed to the user that explains why the button is disabled if invalid data is present in the form

Reproduces how often:

Easily reproduced
@josheleonard josheleonard added design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Jan 4, 2023
@josheleonard josheleonard self-assigned this Jan 4, 2023
@josheleonard josheleonard added this to Web3 Jan 4, 2023
@josheleonard josheleonard moved this to In Progress in Web3 Jan 4, 2023
@josheleonard josheleonard mentioned this issue Jan 5, 2023
Merged
25 tasks
@github-project-automation github-project-automation bot moved this from In Progress to Done in Web3 Jan 6, 2023
@brave-builds brave-builds added this to the 1.49.x - Nightly milestone Jan 6, 2023
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.49.108 Chromium: 110.0.5481.104 (Official Build) beta (64-bit)
Revision 46de4a7f41979e829b430bc1ee30ef483aa227ac-refs/branch-heads/5481_77@{#19}
OS Linux
Token NFT
image image

Verification passed on

Brave 1.49.108 Chromium: 110.0.5481.104 (Official Build) beta (64-bit)
Revision 46de4a7f41979e829b430bc1ee30ef483aa227ac-refs/branch-heads/5481_77@{#19}
OS Windows 11 Version 22H2 (Build 22621.755)
Token NFT
image image

Verification passed on

Brave 1.49.108 Chromium: 110.0.5481.104 (Official Build) beta (arm64)
Revision 46de4a7f41979e829b430bc1ee30ef483aa227ac-refs/branch-heads/5481_77@{#19}
OS macOS Version 13.0 (Build 22A380)
Token NFT
image image

@LaurenWags LaurenWags mentioned this issue Mar 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josheleonard josheleonard

Labels
design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.49.x - Release
Development

Successfully merging a pull request may close this issue.

fix: add token form - display disabled btn reason brave/brave-core
3 participants
@srirambv @josheleonard @brave-builds