Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome branding present in Notification Permission popup #2762

Closed
lynchpin4 opened this issue Dec 30, 2018 · 1 comment
Closed

Chrome branding present in Notification Permission popup #2762

lynchpin4 opened this issue Dec 30, 2018 · 1 comment
Labels
closed/invalid closed/not-actionable feature/url-bar needs-more-info The report requires more detail before we can decide what to do with this issue.

Comments

@lynchpin4
Copy link

lynchpin4 commented Dec 30, 2018

Updated, closed as this is part of Facebook's featureset.

The location for their popup refers to the position of Chrome's URL bar in their code.

Maybe ask them to check to Brave's user agent string?

Description

Text in notification permission denial popup still refers to Chrome, should refer to Brave

Steps to Reproduce

  1. Open Facebook, which attempts to ask for notification permissions
  2. Deny request

Actual result:

image

Reproduces how often:

Easily reproduced

Brave version (brave info)

Brave | 0.60.5 Chromium: 72.0.3626.28 (Official Build) dev (64-bit)
Revision | 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? Yes
@srirambv
Copy link
Contributor

Please update the issue with the template and add details of the browser version you are seeing this.

Regarding the location of the notification, I think we should make the wide URL bar default and have the option to shrink it in settings. @petemill thoughts?

@srirambv srirambv added feature/url-bar needs-more-info The report requires more detail before we can decide what to do with this issue. labels Dec 31, 2018
@srirambv srirambv added this to the 1.x Backlog milestone Dec 31, 2018
@srirambv srirambv removed this from the 1.x Backlog milestone Jan 1, 2019
@NejcZdovc NejcZdovc added this to the Dupe / Invalid / Not actionable milestone Jan 2, 2019
@rebron rebron removed this from the Dupe / Invalid / Not actionable milestone May 8, 2019
@NejcZdovc NejcZdovc added this to the Dupe / Invalid / Not actionable milestone Jun 3, 2019
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/invalid closed/not-actionable feature/url-bar needs-more-info The report requires more detail before we can decide what to do with this issue.
Projects
None yet
Development

No branches or pull requests

5 participants