Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure default account names on wallet are shown in full #27612

Closed
HEagle18 opened this issue Jan 3, 2023 · 1 comment · Fixed by brave/brave-core#16515
Closed

Make sure default account names on wallet are shown in full #27612

HEagle18 opened this issue Jan 3, 2023 · 1 comment · Fixed by brave/brave-core#16515
Assignees
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include

Comments

@HEagle18
Copy link

HEagle18 commented Jan 3, 2023

Description

Right now, parts of the account name on the panel are not shown. We should change the default limit to show the full account name.
Screenshot 2023-01-03 at 01 12 37

Steps to Reproduce

Actual result:

Expected result:

Reproduces how often:

Desktop Brave version:

Android Device details:

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@HEagle18 HEagle18 added feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Jan 3, 2023
@HEagle18 HEagle18 added this to Web3 Jan 3, 2023
@Douglashdaniel Douglashdaniel moved this to In Progress in Web3 Jan 3, 2023
@Douglashdaniel Douglashdaniel added QA/Yes release-notes/include and removed OS/Android Fixes related to Android browser functionality labels Jan 3, 2023
@Douglashdaniel Douglashdaniel moved this from In Progress to In Review in Web3 Jan 3, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Jan 4, 2023
@brave-builds brave-builds added this to the 1.48.x - Nightly milestone Jan 4, 2023
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.48.132 Chromium: 109.0.5414.87 (Official Build) beta (64-bit)
Revision 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS Linux

Verification passed on

Brave 1.48.132 Chromium: 109.0.5414.87 (Official Build) beta (64-bit)
Revision 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS Windows 11 Version 22H2 (Build 22621.755)

Verification passed on

Brave 1.48.132 Chromium: 109.0.5414.87 (Official Build) beta (arm64)
Revision 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS macOS Version 13.0 (Build 22A380)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants