Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'Lock Wallet' -- > 'Lock wallet' #27571

Closed
jenn-rhim opened this issue Dec 29, 2022 · 1 comment · Fixed by brave/brave-core#16649
Closed

'Lock Wallet' -- > 'Lock wallet' #27571

jenn-rhim opened this issue Dec 29, 2022 · 1 comment · Fixed by brave/brave-core#16649
Assignees
@Douglashdaniel
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes needs-text-change This change requires some careful wording. OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.49.x - Release

Comments

@jenn-rhim
Copy link

Should be lower case 'wallet' as it's referring to general wallet, not proper name of the product.

@kleantzogu @jamesmudgett
@rebron rebron added the feature/web3/wallet Integrating Ethereum+ wallet support label Dec 29, 2022
@rebron rebron added this to Web3 Dec 29, 2022
@bsclifton bsclifton added the needs-text-change This change requires some careful wording. label Dec 30, 2022
@Douglashdaniel Douglashdaniel self-assigned this Jan 12, 2023
@Douglashdaniel Douglashdaniel moved this to In Progress in Web3 Jan 12, 2023
@Douglashdaniel Douglashdaniel added QA/Yes release-notes/exclude release-notes/include front-end-change This task is a front end task and doesn't need any C++ changes and removed release-notes/exclude labels Jan 12, 2023
@Douglashdaniel Douglashdaniel mentioned this issue Jan 12, 2023
Merged
25 tasks
@Douglashdaniel Douglashdaniel moved this from In Progress to In Review in Web3 Jan 12, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Jan 13, 2023
@brave-builds brave-builds added this to the 1.49.x - Nightly milestone Jan 13, 2023
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.49.91 Chromium: 110.0.5481.77 (Official Build) beta (64-bit)
Revision 65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS Linux
  • Verified steps from brave/brave-core#16649
  • Verified Lock Wallet is now Lock wallet
  • Verified text change on both portfolio and panel
Portfolio Panel
image image

Verification passed on

Brave 1.49.91 Chromium: 110.0.5481.77 (Official Build) beta (64-bit)
Revision 65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS Windows 11 Version 22H2 (Build 22621.755)
  • Verified steps from brave/brave-core#16649
  • Verified Lock Wallet is now Lock wallet
  • Verified text change on both portfolio and panel
Portfolio Panel
image image

Verification passed on

Brave 1.49.91 Chromium: 110.0.5481.77 (Official Build) beta (arm64)
Revision 65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS macOS Version 13.0 (Build 22A380)
  • Verified steps from brave/brave-core#16649
  • Verified Lock Wallet is now Lock wallet
  • Verified text change on both portfolio and panel
Portfolio Panel
image image

@LaurenWags LaurenWags mentioned this issue Mar 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes needs-text-change This change requires some careful wording. OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.49.x - Release
Development

Successfully merging a pull request may close this issue.

fix(wallet): Lock wallet text case brave/brave-core
6 participants
@jenn-rhim @bsclifton @rebron @srirambv @Douglashdaniel @brave-builds