Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement NFT Details screen #27302

Closed
srirambv opened this issue Dec 12, 2022 · 5 comments
Closed

Implement NFT Details screen #27302

srirambv opened this issue Dec 12, 2022 · 5 comments
Labels
closed/duplicate Issue has already been reported feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality

Comments

@srirambv
Copy link
Contributor

Description

Can't open NFT's added via token registry

Steps to reproduce

  1. Install 1.4.125 build
  2. Add a CryptoKitties NFT or Punks Comic NFT's
  3. Go back to portfolio and click on the NFT added in step 2, doesn't load the NFT details view

Actual result

Can't open NFT's added via token registry

Expected result

Should open NFT details view

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Not checked

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): All
  • Android version: 12

Brave version

1.47.125 x64 Beta

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards?NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @wchen342 @Pavneet-Sing

@srirambv srirambv added bug QA/Yes feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Dec 12, 2022
@srirambv srirambv added this to Web3 Dec 12, 2022
@srirambv
Copy link
Contributor Author

This seems to be an issue for other tokens as well

NFT.Details.mp4

@wchen342
Copy link

Isn't that what supposed to happen because of #23507? Disable NFT details until portfolio page is implemented.

@srirambv
Copy link
Contributor Author

Ok yes I hadn't checked the test plan for #23507. Do I keep the issue open and we can use this for NFT details view or do we have an open issue in which case I can close this one as invalid

@wchen342
Copy link

I don't think there is another issue for this so please keep it open. Maybe change the title to something like "implement NFT portfolio page"?

@srirambv srirambv changed the title Can't open NFT's added via token registry Implement NFT Details screen Dec 12, 2022
@srirambv srirambv removed the bug label Dec 12, 2022
@Pavneet-Sing
Copy link

Pavneet-Sing commented Dec 13, 2022

Likely a dupe of NFT asset details screen

@Pavneet-Sing Pavneet-Sing moved this to Done in Web3 Dec 13, 2022
@Pavneet-Sing Pavneet-Sing added closed/duplicate Issue has already been reported and removed QA/Yes labels Dec 13, 2022
@Pavneet-Sing Pavneet-Sing added this to the Closed / Dupe / Invalid milestone Dec 13, 2022
@Pavneet-Sing Pavneet-Sing removed this from Web3 Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality
Projects
None yet
Development

No branches or pull requests

3 participants