Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve wallet networks list UX #27058

Closed
supermassive opened this issue Nov 30, 2022 · 1 comment · Fixed by brave/brave-core#16199
Closed

Improve wallet networks list UX #27058

supermassive opened this issue Nov 30, 2022 · 1 comment · Fixed by brave/brave-core#16199

Comments

@supermassive
Copy link

supermassive commented Nov 30, 2022

From https://bravesoftware.slack.com/archives/C02S9LFEXU4/p1669733487021219

  • Maybe just have all testnets shown in list of networks but have the eye (set to hidden) for all of them by default. The disadvantage is you'd have to show each test network individually. The advantage is maybe you don't wall all of them to be seen anyway.
  • And get rid of the "show test networks" toggle
  • Also let's show a disabled eye icon for default networks with a proper tooltip.
  • For portfolio and nft screen network component should list visible test networks in separate bottom section.
@srirambv
Copy link
Contributor

srirambv commented Feb 2, 2023

Verification passed on

Brave 1.48.151 Chromium: 109.0.5414.119 (Official Build) beta (64-bit)
Revision 772095164c7d5d4e73160f858efed3b5e87eca83-refs/branch-heads/5414@{#1458}
OS Linux
  • Verified steps from brave/brave-core#16199
  • Verified test networks are disabled by default on a clean profile and upgrade profile where it wasn't enabled
  • Verified on Portfolio page and NFT page Test networks are listed under its own heading in the network picker
  • Verified eye button is always shown on networks setting and also shows tooltip when hovered over
27058.mp4

Verification passed on

Brave 1.48.151 Chromium: 109.0.5414.119 (Official Build) beta (64-bit)
Revision 772095164c7d5d4e73160f858efed3b5e87eca83-refs/branch-heads/5414@{#1458}
OS Windows 11 Version 22H2 (Build 22621.755)
  • Verified steps from brave/brave-core#16199
  • Verified test networks are disabled by default on a clean profile and upgrade profile where it wasn't enabled
  • Verified on Portfolio page and NFT page Test networks are listed under its own heading in the network picker
  • Verified eye button is always shown on networks setting and also shows tooltip when hovered over
27058.mp4

Verification passed on

Brave 1.48.151 Chromium: 109.0.5414.119 (Official Build) beta (arm64)
Revision 772095164c7d5d4e73160f858efed3b5e87eca83-refs/branch-heads/5414@{#1458}
OS macOS Version 13.0 (Build 22A380)
  • Verified steps from brave/brave-core#16199
  • Verified test networks are disabled by default on a clean profile and upgrade profile where it wasn't enabled
  • Verified on Portfolio page and NFT page Test networks are listed under its own heading in the network picker
  • Verified eye button is always shown on networks setting and also shows tooltip when hovered over
27058.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants