Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show error is resolved domain is address is your own address #26918

Closed
Douglashdaniel opened this issue Nov 22, 2022 · 1 comment · Fixed by brave/brave-core#16050
Closed
Assignees
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include

Comments

@Douglashdaniel
Copy link

Description

Resolved domain address does not show an error if the address is the same as your sending account.

Steps to Reproduce

Actual result:

Screen.Recording.2022-11-21.at.7.29.32.PM.mov

Expected result:

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@Douglashdaniel Douglashdaniel added bug QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Nov 22, 2022
@Douglashdaniel Douglashdaniel self-assigned this Nov 22, 2022
@Douglashdaniel Douglashdaniel moved this to In Progress in Web3 Nov 22, 2022
@Douglashdaniel Douglashdaniel moved this from In Progress to In Review in Web3 Nov 22, 2022
Repository owner moved this from In Review to Done in Web3 Nov 22, 2022
@brave-builds brave-builds added this to the 1.47.x - Nightly milestone Nov 22, 2022
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.47.126 Chromium: 108.0.5359.99 (Official Build) beta (64-bit)
Revision 410951fc34bb4b2cbf182231f9f779efaafaf682-refs/branch-heads/5359_71@{#9}
OS Linux
  • Verified steps from brave/brave-core#16050
  • Verified Review Order button updates text to The receiving address is your own address and doesn't let you continue
26918.mp4

Verification passed on

Brave 1.47.126 Chromium: 108.0.5359.99 (Official Build) beta (64-bit)
Revision 410951fc34bb4b2cbf182231f9f779efaafaf682-refs/branch-heads/5359_71@{#9}
OS Windows 11 Version 22H2 (Build 22621.755)
  • Verified steps from brave/brave-core#16050
  • Verified Review Order button updates text to The receiving address is your own address and doesn't let you continue
26918.mp4

Verification passed on

Brave 1.47.126 Chromium: 108.0.5359.99 (Official Build) beta (arm64)
Revision 410951fc34bb4b2cbf182231f9f779efaafaf682-refs/branch-heads/5359_71@{#9}
OS macOS Version 13.0 (Build 22A380)
  • Verified steps from brave/brave-core#16050
  • Verified Review Order button updates text to The receiving address is your own address and doesn't let you continue
26918.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants