-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync sends bookmarks even when chain is not fully created #2687
Comments
@AlexeyBarabash is this similar to #2148. In #2148 bookmark sync was disabled but still ended up showing on the other device. This issue mentioned about the logs in console about sending records even though sync chain isnt created. |
@srirambv #2687 is related to sync ui v2, when we have to force to have at least 2 devices in chain and show sync code (get seed) with a probability that sync chain will not be created. #2148 happened because several bookmarks from b-c were sent before switching option off. |
Verified passed with
Verification passed on
Used STR from description Verification passed on
|
Description
With Sync UI v2 sync chain is considered created when it has two or more devices.
Now we can see that bookmarks are sent even if there is only one device in chain, and the secon is not connected yet.
Steps to Reproduce
1. Launch brave browser in terminalSync lib output into terminal is not available on release build, so updating this STR
Actual result:
sending record: {"action":0,"bookmark":{ ...
Expected result:
Reproduces how often:
Easyly
Brave version (brave://version info)
Reproducible on current release:
Reproduced on nightly for sure.
The text was updated successfully, but these errors were encountered: