Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move sidebar to the right when vertical tab strip is enabled #26855

Closed
Tracked by #24717
sangwoo108 opened this issue Nov 18, 2022 · 0 comments · Fixed by brave/brave-core#16015
Closed
Tracked by #24717

Move sidebar to the right when vertical tab strip is enabled #26855

sangwoo108 opened this issue Nov 18, 2022 · 0 comments · Fixed by brave/brave-core#16015
Assignees
Labels
feature/vertical-tabs OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude

Comments

@sangwoo108
Copy link

sangwoo108 commented Nov 18, 2022

When a user didn't choose sidebar's position explicitly, we should move sidebar to the right. This is because having both vertical tabs and sidebar on the right feels bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/vertical-tabs OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants