Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-existing token ID cause empty Portfolio page #26803

Closed
wchen342 opened this issue Nov 16, 2022 · 5 comments
Closed

Non-existing token ID cause empty Portfolio page #26803

wchen342 opened this issue Nov 16, 2022 · 5 comments
Assignees
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include

Comments

@wchen342
Copy link

wchen342 commented Nov 16, 2022

Description

A non-existing token ID for NFT will cause the portfolio page to not show any information upon next opening of wallet.

Steps to reproduce

  1. Go to wallet->Edit visible assets, add a normal NFT.
  2. Add another NFT, but this time set Token ID to a non-exisitng number (i.e. the corresponding NFT doesn't exist).
  3. Quit to NTP, open wallet again.
  4. Portfolio screen now has no graph and no token list., only network selector and "Edit viswible assets" button.

Actual result

Portfolio screen shows no graph and no token list.

Expected result

Token list and graph show normally.

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Yes
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Phone
  • Android version: 12

Brave version

1.45.123

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @srirambv @SergeyZhukovsky @Pavneet-Sing @jamesmudgett

@wchen342 wchen342 added bug QA/Yes feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Nov 16, 2022
@wchen342 wchen342 added this to Web3 Nov 16, 2022
@muliswilliam
Copy link

@wchen342 What does "Quit to NTP" mean?

@muliswilliam muliswilliam self-assigned this Nov 16, 2022
@muliswilliam muliswilliam moved this to Backlog in Web3 Nov 16, 2022
@wchen342
Copy link
Author

@muliswilliam NTP is the new tab page (the first page you see when entering the browser), I probably shall just say quit wallet.

@wchen342
Copy link
Author

wchen342 commented Nov 16, 2022

Also this is an Android issue, not a desktop one.

@muliswilliam muliswilliam removed their assignment Nov 17, 2022
@wchen342 wchen342 self-assigned this Nov 17, 2022
@wchen342
Copy link
Author

Resolved by brave/brave-core/pull/16108.

Repository owner moved this from Backlog to Done in Web3 Nov 29, 2022
@wchen342 wchen342 added this to the 1.48.x - Nightly milestone Nov 29, 2022
@srirambv
Copy link
Contributor

srirambv commented Feb 6, 2023

Verification passed on the following devices running 1.48.155 x64 build

  • Verified steps from issue description
  • Verified adding an invalid/non-existent token ID doesn't cause the graph to show empty value
Oppo Reno 5 (Android 13) Lenovo Tab (Android 12)
26803-ARM.mp4
26803-Tab.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
Archived in project
Development

No branches or pull requests

3 participants