Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send Tab Build out NFT Info Tooltip #26753

Closed
Douglashdaniel opened this issue Nov 14, 2022 · 1 comment · Fixed by brave/brave-core#15954
Closed

Send Tab Build out NFT Info Tooltip #26753

Douglashdaniel opened this issue Nov 14, 2022 · 1 comment · Fixed by brave/brave-core#15954
Assignees
@Douglashdaniel
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.47.x - Release

Comments

@Douglashdaniel
Copy link

Description

Build out the NFT Info tooltip for the new Send tab

Screen Shot 2022-11-14 at 1 27 17 PM
@Douglashdaniel Douglashdaniel added QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Nov 14, 2022
@Douglashdaniel Douglashdaniel self-assigned this Nov 14, 2022
@Douglashdaniel Douglashdaniel moved this to In Progress in Web3 Nov 14, 2022
@Douglashdaniel Douglashdaniel mentioned this issue Nov 15, 2022
Merged
25 tasks
@Douglashdaniel Douglashdaniel moved this from In Progress to In Review in Web3 Nov 15, 2022
Repository owner moved this from In Review to Done in Web3 Nov 16, 2022
@brave-builds brave-builds added this to the 1.47.x - Nightly milestone Nov 16, 2022
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.47.126 Chromium: 108.0.5359.99 (Official Build) beta (64-bit)
Revision 410951fc34bb4b2cbf182231f9f779efaafaf682-refs/branch-heads/5359_71@{#9}
OS Linux
  • Verified steps from brave/brave-core#15954
  • Verified hover over info button on NFT shows NFT details in Tooltip
  • Verified clicking on the links opens correct block explorer links for the selected NFT
  • Encountered #27369 & #27370
26753.mp4

Verification passed on

Brave 1.47.126 Chromium: 108.0.5359.99 (Official Build) beta (64-bit)
Revision 410951fc34bb4b2cbf182231f9f779efaafaf682-refs/branch-heads/5359_71@{#9}
OS Windows 11 Version 22H2 (Build 22621.755)
  • Verified steps from brave/brave-core#15954
  • Verified hover over info button on NFT shows NFT details in Tooltip
  • Verified clicking on the links opens correct block explorer links for the selected NFT
  • Encountered #27369 & #27370
26753.mp4

Verification passed on

Brave 1.47.126 Chromium: 108.0.5359.99 (Official Build) beta (arm64)
Revision 410951fc34bb4b2cbf182231f9f779efaafaf682-refs/branch-heads/5359_71@{#9}
OS macOS Version 13.0 (Build 22A380)
  • Verified steps from brave/brave-core#15954
  • Verified hover over info button on NFT shows NFT details in Tooltip
  • Verified clicking on the links opens correct block explorer links for the selected NFT
  • Encountered #27369 & #27370
26753.mov

@LaurenWags LaurenWags mentioned this issue Jan 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.47.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): Built out NFT Info Tooltip brave/brave-core
3 participants
@srirambv @Douglashdaniel @brave-builds