Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test if we can move vertical tabs next to the entire contents area #26688

Open
Tracked by #24717
sangwoo108 opened this issue Nov 11, 2022 · 1 comment
Open
Tracked by #24717

Test if we can move vertical tabs next to the entire contents area #26688

sangwoo108 opened this issue Nov 11, 2022 · 1 comment
Assignees
@sangwoo108
Labels
feature/vertical-tabs OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA/No release-notes/exclude

Comments

@sangwoo108
Copy link

sangwoo108 commented Nov 11, 2022 •
edited
Loading

Problem

Currently, vertical tabstrip is under top container. Because of this, vertical tabs could move up and down when changing the active tab.

Possible solution

If vertical tabs could be next to the entire clients area, which means that vertical tab region is a sibling of browser's contents,

Difficulties

  • Need to hack browser view layout heavily. - they don't have room to plug hrorizontal inset.

Our design team wants to explore this more. Make a switch for this.
@sangwoo108 sangwoo108 mentioned this issue Nov 11, 2022
Closed
26 tasks
@sangwoo108 sangwoo108 self-assigned this Nov 11, 2022
@sangwoo108 sangwoo108 added priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude OS/Desktop feature/vertical-tabs labels Nov 11, 2022
@sangwoo108 sangwoo108 mentioned this issue Nov 12, 2022
Closed
25 tasks
@sangwoo108 sangwoo108 added priority/P4 Planned work. We expect to get to it "soon". and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Nov 12, 2022
@sangwoo108
Copy link
Author

prototyping is done. Need more design guide

@sangwoo108 sangwoo108 mentioned this issue Nov 12, 2022
Closed
@sangwoo108 sangwoo108 added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P4 Planned work. We expect to get to it "soon". labels Nov 14, 2022
@sangwoo108 sangwoo108 added priority/P4 Planned work. We expect to get to it "soon". and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sangwoo108 sangwoo108

Labels
feature/vertical-tabs OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA/No release-notes/exclude
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP: move vertical tabs out of contents layout brave/brave-core
1 participant
@sangwoo108