Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Uint8Array private key import for Solana #26672

Closed
darkdh opened this issue Nov 10, 2022 · 1 comment · Fixed by brave/brave-core#15959
Closed

Support Uint8Array private key import for Solana #26672

darkdh opened this issue Nov 10, 2022 · 1 comment · Fixed by brave/brave-core#15959
Assignees
@darkdh
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
1.47.x - Release

Comments

@darkdh
Copy link
Member

darkdh commented Nov 10, 2022

https://solflare.com/ export private key in Uint8Array instead of base58 encoding.
Screen Shot 2022-11-10 at 09 45 41
@darkdh darkdh added feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop labels Nov 10, 2022
@darkdh darkdh added this to Web3 Nov 10, 2022
@jamesmudgett jamesmudgett moved this to Backlog in Web3 Nov 11, 2022
@darkdh darkdh moved this from Backlog to In Progress in Web3 Nov 15, 2022
@darkdh darkdh self-assigned this Nov 15, 2022
@darkdh darkdh mentioned this issue Nov 15, 2022
Merged
25 tasks
@darkdh darkdh moved this from In Progress to In Review in Web3 Nov 15, 2022
Repository owner moved this from In Review to Done in Web3 Nov 16, 2022
@brave-builds brave-builds added this to the 1.47.x - Nightly milestone Nov 16, 2022
@srirambv
Copy link
Contributor

srirambv commented Jan 9, 2023

Verification passed on

Brave 1.47.164 Chromium: 109.0.5414.74 (Official Build) (64-bit)
Revision e7c5703604daa9cc128ccf5a5d3e993513758913-refs/branch-heads/5414@{#1172}
OS Linux
  • Verified steps from brave/brave-core#15959
  • Verified able to import Uint8Array private key for Solana Account
26672.mp4

Verification passed on

Brave 1.47.164 Chromium: 109.0.5414.74 (Official Build) (64-bit)
Revision e7c5703604daa9cc128ccf5a5d3e993513758913-refs/branch-heads/5414@{#1172}
OS Windows 11 Version 22H2 (Build 22621.755)
  • Verified steps from brave/brave-core#15959
  • Verified able to import Uint8Array private key for Solana Account
26672.mp4

Verification passed on

Brave 1.47.164 Chromium: 109.0.5414.74 (Official Build) (arm64)
Revision e7c5703604daa9cc128ccf5a5d3e993513758913-refs/branch-heads/5414@{#1172}
OS macOS Version 13.0 (Build 22A380)
  • Verified steps from brave/brave-core#15959
  • Verified able to import Uint8Array private key for Solana Account
26772.mov

@LaurenWags LaurenWags mentioned this issue Jan 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@darkdh darkdh

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.47.x - Release
Development

Successfully merging a pull request may close this issue.

Support Uint8Array format when importing Solana private key brave/brave-core
3 participants
@darkdh @srirambv @brave-builds