Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persist show/hide wallet portfolio chart user pref #26557

Closed
josheleonard opened this issue Nov 4, 2022 · 1 comment · Fixed by brave/brave-core#15807
Closed

Persist show/hide wallet portfolio chart user pref #26557

josheleonard opened this issue Nov 4, 2022 · 1 comment · Fixed by brave/brave-core#15807
Assignees
@josheleonard
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.47.x - Release

Comments

@josheleonard
Copy link

Description

The chart on the Brave Wallet portfolio overview screen should remain displayed/hidden based on subsequent page loads when the user shows or hide the chart.
@josheleonard josheleonard added QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Nov 4, 2022
@josheleonard josheleonard self-assigned this Nov 4, 2022
@josheleonard josheleonard added this to Web3 Nov 4, 2022
@josheleonard josheleonard mentioned this issue Nov 4, 2022
Merged
25 tasks
@josheleonard josheleonard moved this to Done in Web3 Nov 7, 2022
@brave-builds brave-builds added this to the 1.47.x - Nightly milestone Nov 7, 2022
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.47.126 Chromium: 108.0.5359.99 (Official Build) beta (64-bit)
Revision 410951fc34bb4b2cbf182231f9f779efaafaf682-refs/branch-heads/5359_71@{#9}
OS Linux
26557.mp4

Verification passed on

Brave 1.47.126 Chromium: 108.0.5359.99 (Official Build) beta (64-bit)
Revision 410951fc34bb4b2cbf182231f9f779efaafaf682-refs/branch-heads/5359_71@{#9}
OS Windows 11 Version 22H2 (Build 22621.755)
26557.mp4

Verification passed on

Brave 1.47.126 Chromium: 108.0.5359.99 (Official Build) beta (arm64)
Revision 410951fc34bb4b2cbf182231f9f779efaafaf682-refs/branch-heads/5359_71@{#9}
OS macOS Version 13.0 (Build 22A380)
26557.mov

@LaurenWags LaurenWags mentioned this issue Jan 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josheleonard josheleonard

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.47.x - Release
Development

Successfully merging a pull request may close this issue.

Fix store hide portfolio chart pref brave/brave-core
3 participants
@srirambv @josheleonard @brave-builds