Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Brave News V2 UI should lazy load images #26161

Closed
fallaciousreasoning opened this issue Oct 20, 2022 · 0 comments · Fixed by brave/brave-core#15586
Closed

The Brave News V2 UI should lazy load images #26161

fallaciousreasoning opened this issue Oct 20, 2022 · 0 comments · Fixed by brave/brave-core#15586
Assignees
@fallaciousreasoning
Labels
OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Milestone
1.46.x - Release

Comments

@fallaciousreasoning
Copy link

Currently, we load images for all Publishers as soon as we display them. This triggers a number of unnecessary requests at startup, and likely wastes a bit of data.

We should change this to only load the images when we want to display them.
@fallaciousreasoning fallaciousreasoning mentioned this issue Oct 21, 2022
Merged
25 tasks
@fallaciousreasoning fallaciousreasoning mentioned this issue Oct 21, 2022
Closed
13 tasks
@fallaciousreasoning fallaciousreasoning self-assigned this Oct 21, 2022
@rebron rebron added priority/P4 Planned work. We expect to get to it "soon". priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P4 Planned work. We expect to get to it "soon". labels Oct 21, 2022
@brave-builds brave-builds added this to the 1.47.x - Nightly milestone Oct 24, 2022
@stephendonner stephendonner mentioned this issue Nov 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fallaciousreasoning fallaciousreasoning

Labels
OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Projects
None yet
Milestone
1.46.x - Release
Development

Successfully merging a pull request may close this issue.

Lazy load images in the Brave News V2 UI brave/brave-core
4 participants
@kjozwiak @rebron @fallaciousreasoning @brave-builds