Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate SNS into Brave wallet to allow users send tokens via .sol domains directly #25907

Closed
bbondy opened this issue Oct 11, 2022 · 1 comment · Fixed by brave/brave-core#15617
Closed

Integrate SNS into Brave wallet to allow users send tokens via .sol domains directly #25907

bbondy opened this issue Oct 11, 2022 · 1 comment · Fixed by brave/brave-core#15617
Assignees
@supermassive
Labels
feature/web3/wallet/core feature/web3/wallet/solana feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.47.x - Release

Comments

@bbondy
Copy link
Member

bbondy commented Oct 11, 2022 •
edited by supermassive
Loading

Integrate SNS into Brave wallet to allow users send tokens via .sol domains directly
github doc: https://bonfida.github.io/solana-name-service-guide/wallet-guide.html

Done in #26652 Complete the native resolution of SNS records inside Brave’s browser github doc: https://github.com/Bonfida/name-resolver

cc @yrliou
@bbondy bbondy added priority/P2 A bad problem. We might uplift this to the next planned release. feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality feature/web3/wallet/solana feature/web3/wallet/core feature/web3/ddns labels Oct 11, 2022
@bbondy bbondy added this to Web3 Oct 11, 2022
@supermassive supermassive moved this to In Progress in Web3 Oct 13, 2022
@supermassive supermassive mentioned this issue Nov 9, 2022
Merged
25 tasks
Repository owner moved this from In Progress to Done in Web3 Nov 9, 2022
@brave-builds brave-builds added this to the 1.47.x - Nightly milestone Nov 9, 2022
@supermassive supermassive added QA/Yes release-notes/include and removed OS/Android Fixes related to Android browser functionality OS/iOS Fixes related to iOS browser functionality feature/web3/ddns labels Nov 10, 2022
@bbondy bbondy mentioned this issue Dec 13, 2022
Closed
@srirambv
Copy link
Contributor

srirambv commented Jan 9, 2023

Verification passed on

Brave 1.47.164 Chromium: 109.0.5414.74 (Official Build) (64-bit)
Revision e7c5703604daa9cc128ccf5a5d3e993513758913-refs/branch-heads/5414@{#1172}
OS Linux
  • Verified steps from brave/brave-core#15617
  • Verified with RPC endpoint set to https://mainnet-beta-solana.brave.com/rpc
  • Verified onybose.sol resolves to 5wytVPbjLb2VCXbynhUQabEZZD2B6Wxrkvwm6v6Cuy5X (SOL record on domain)
  • Verified brave.onybose.sol resolves to 3nCNLXJw9FEXgByDLffv2mC9233EdFHnoJx2MySRrhuR (SOL record on domain)
  • Verified bonfida.sol resolves to HKKp49qGWXd639QsuH7JiLijfVW5UtCVY4s1n2HANwEA (NFT domain)
25907.mp4

Verification passed on

Brave 1.47.164 Chromium: 109.0.5414.74 (Official Build) (64-bit)
Revision e7c5703604daa9cc128ccf5a5d3e993513758913-refs/branch-heads/5414@{#1172}
OS Windows 11 Version 22H2 (Build 22621.755)
  • Verified steps from brave/brave-core#15617
  • Verified with RPC endpoint set to https://mainnet-beta-solana.brave.com/rpc
  • Verified onybose.sol resolves to 5wytVPbjLb2VCXbynhUQabEZZD2B6Wxrkvwm6v6Cuy5X (SOL record on domain)
  • Verified brave.onybose.sol resolves to 3nCNLXJw9FEXgByDLffv2mC9233EdFHnoJx2MySRrhuR (SOL record on domain)
  • Verified bonfida.sol resolves to HKKp49qGWXd639QsuH7JiLijfVW5UtCVY4s1n2HANwEA (NFT domain)
25907.mp4

Verification passed on

Brave 1.47.164 Chromium: 109.0.5414.74 (Official Build) (arm64)
Revision e7c5703604daa9cc128ccf5a5d3e993513758913-refs/branch-heads/5414@{#1172}
OS macOS Version 13.0 (Build 22A380)
  • Verified steps from brave/brave-core#15617
  • Verified with RPC endpoint set to https://mainnet-beta-solana.brave.com/rpc
  • Verified onybose.sol resolves to 5wytVPbjLb2VCXbynhUQabEZZD2B6Wxrkvwm6v6Cuy5X (SOL record on domain)
  • Verified brave.onybose.sol resolves to 3nCNLXJw9FEXgByDLffv2mC9233EdFHnoJx2MySRrhuR (SOL record on domain)
  • Verified bonfida.sol resolves to HKKp49qGWXd639QsuH7JiLijfVW5UtCVY4s1n2HANwEA (NFT domain)
25907.mov

@LaurenWags LaurenWags mentioned this issue Jan 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@supermassive supermassive

Labels
feature/web3/wallet/core feature/web3/wallet/solana feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.47.x - Release
Development

Successfully merging a pull request may close this issue.

SNS support for wallet brave/brave-core
4 participants
@supermassive @bbondy @srirambv @brave-builds