Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Brave News V2]: All favicons should be loaded when viewing the customize dialog #25891

Closed
fallaciousreasoning opened this issue Oct 10, 2022 · 1 comment
Closed

[Brave News V2]: All favicons should be loaded when viewing the customize dialog #25891

fallaciousreasoning opened this issue Oct 10, 2022 · 1 comment
Assignees
@fallaciousreasoning

Comments

@fallaciousreasoning
Copy link

Blocks: #25890

Before we can enable the Brave News V2 UI, we should make sure we request favicons for all publishers in the user's locale, instead of only the ones they are subscribed to. This issue was raised in the security review: https://github.com/brave/security/issues/1055
@fallaciousreasoning fallaciousreasoning self-assigned this Oct 10, 2022
@fallaciousreasoning
Copy link
Author

fallaciousreasoning commented Oct 20, 2022 •
edited
Loading

Closing this as per https://github.com/brave/security/issues/1055#issuecomment-1276818216 it doesn't sound like an issue if we serve the images from the private CDN, and we have bandwidth concerns

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fallaciousreasoning fallaciousreasoning

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fallaciousreasoning