Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Same-site debouncing restriction should be based on eTLD+1 #25859

Closed
pilgrim-brave opened this issue Oct 7, 2022 · 1 comment · Fixed by brave/brave-core#15392
Closed

Same-site debouncing restriction should be based on eTLD+1 #25859

pilgrim-brave opened this issue Oct 7, 2022 · 1 comment · Fixed by brave/brave-core#15392
Assignees
Labels
OS/Android Fixes related to Android browser functionality OS/Desktop QA/No release-notes/include

Comments

@pilgrim-brave
Copy link

pilgrim-brave commented Oct 7, 2022

Currently we don't debounce a link if two hops in the chain have the same origin. This should be expanded to be eTLD+1 matches, not just origin.

For example, currently this chain is not debounced in Brave:

from.example -> a.click.example/bounce -> a.click.example/dest

bc /bounce and /dest share the origin.

However, this chain would be debounced:

from.example -> a.click.example/bounce -> b.click.example/dest

The correct behavior is for neither of the above redirect chains to be debounced

@kjozwiak
Copy link
Member

Labelled as QA/No after discussing the above with @pes10k and @pilgrim-brave via the Slack thread that @LaurenWags started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS/Android Fixes related to Android browser functionality OS/Desktop QA/No release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants