Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Rewards extension #25792

Closed
Miyayes opened this issue Oct 4, 2022 · 2 comments · Fixed by brave/brave-core#15342
Closed

Remove Rewards extension #25792

Miyayes opened this issue Oct 4, 2022 · 2 comments · Fixed by brave/brave-core#15342
Assignees
@zenparsing
Labels
feature/rewards OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Yes release-notes/exclude
Milestone
1.47.x - Release

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Oct 4, 2022 •
edited
Loading

Description

Given #22423, remove remaining code and flags for using the Rewards extension and depend entirely on the new WebUI Rewards panel.

Test Steps

  1. Go into brave://flags/, make sure there is no more flag for extension vs. webUI version of panel.
  2. Make sure the panel is the WebUI panel (e.g., you can pinch zoom the WebUI panel but can’t the extension panel)
@zenparsing zenparsing mentioned this issue Oct 4, 2022
Merged
25 tasks
@brave-builds brave-builds added this to the 1.47.x - Nightly milestone Oct 19, 2022
@Miyayes Miyayes added the priority/P3 The next thing for us to work on. It'll ride the trains. label Oct 19, 2022
@LaurenWags
Copy link
Member

@Miyayes @zenparsing since this one is labelled QA/Yes, a test plan is needed.

Labelling as QA/Blocked until there is one.

cc @kjozwiak @rebron

@LaurenWags LaurenWags added QA/Blocked QA/In-Progress Indicates that QA is currently in progress for that particular issue and removed QA/Blocked labels Dec 2, 2022
@LaurenWags
Copy link
Member

Verified passed with

Brave | 1.47.119 Chromium: 108.0.5359.99 (Official Build) beta (x86_64)
-- | --
Revision | 410951fc34bb4b2cbf182231f9f779efaafaf682-refs/branch-heads/5359_71@{#9}
OS | macOS Version 12.6.1 (Build 21G217)

Verified test plan from #25792 (comment).

Compared 1.46.140 and 1.47.119. Confirmed 1.47.x version does not contain the webUI flag.
Confirmed able to pinch zoom in webUI panel on 1.47.x, but not 1.46.x.

1.46.140 1.47.119
Screen Shot 2022-12-08 at 5 02 40 PM Screen Shot 2022-12-08 at 4 57 48 PM
Screen Shot 2022-12-08 at 5 03 21 PM Screen Shot 2022-12-08 at 5 01 47 PM

@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zenparsing zenparsing

Labels
feature/rewards OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.47.x - Release
Development

Successfully merging a pull request may close this issue.

Remove the Brave Rewards extension brave/brave-core
4 participants
@zenparsing @Miyayes @LaurenWags @brave-builds