Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Improve Rating Prompts #25777

Closed
timchilds opened this issue Oct 3, 2022 · 3 comments · Fixed by brave/brave-core#16425
Closed

[Android] Improve Rating Prompts #25777

timchilds opened this issue Oct 3, 2022 · 3 comments · Fixed by brave/brave-core#16425

Comments

@timchilds
Copy link

Spec

https://bravesoftware.slack.com/archives/C03MMJ4CHEZ/p1664813123345989?thread_ts=1664813117.013499&cid=C03MMJ4CHEZ

@kjozwiak
Copy link
Member

kjozwiak commented Feb 1, 2023

When running through the above, please keep in mind #27750 and ensure that there's no crashes with the new improved rating modals/prompts.

@Uni-verse Uni-verse added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Feb 3, 2023
@Uni-verse
Copy link
Contributor

Uni-verse commented Feb 6, 2023

Verified on Samsung GS 21 using version:

Brave	1.48.157 Chromium: 110.0.5481.77 (Official Build) (64-bit) 
Revision	65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS	Android 13; Build/TP1A.220624.014

Scenario 1 (Condition: Default Browser set):

  1. Launch App
  2. Set browser to default
  3. Background brave app, change system date/time to 30 days ahead
  4. Open app
  5. Close app
  6. Change date 1 day ahead
  7. Repeat steps 4-7 four times
  8. Close app
  9. Change system time 3 days ahead
  10. Relaunch app
  • Verified user will be prompted with rating modal when brave news is disabled.
  • Verified user rating card shows up in the brave news feed when opting in.
  • Verified user is able to submit rating feedback to app store.
  • Verified user is able to dismiss the user rating modal.
  • Verified user will not be prompted the rating modal if user does not set browser to default.
Example Example Example Example
screenshot-1675463873726 screenshot-1675463889777 screenshot-1675463900202 screenshot-1675463942940

Scenario 2: (Condition: 5 Bookmarks created):

  1. Launch app
  2. Enabled brave news
  3. Bookmark 5 webpages
  4. Background app, change system date/time 30 days ahead
  5. Open app
  • Verified user will be prompted with rating modal when brave news is enabled.
  • Verified user rating card shows up in the brave news feed.
  • Verified user is able to submit rating feedback to app store.
  • Verified user is able to dismiss the user rating modal.
  • Verified user will not be prompted the rating modal if user does not creates 5 bookmarks.
Example Example Example Selecting Sad Emoji
screenshot-1675697653425 screenshot-1675697684750 screenshot-1675697670296 screenshot-1675698115786

Encountered: #28315

@Uni-verse
Copy link
Contributor

Uni-verse commented Feb 6, 2023

Verified on Samsung Galaxy Tab S7 using version:

Brave	1.48.157 Chromium: 110.0.5481.77 (Official Build) (64-bit) 
Revision	65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS	Android 12; Build/SP2A.220305.013

Scenario 1 (Condition: VPN purchased):

  1. Launch App
  2. Purchase VPN
  3. Background brave app, change system date/time to 30 days ahead
  4. Open app
  5. Close app
  6. Change date 1 day ahead
  7. Repeat steps 4-7 four times
  8. Close app
  9. Change system time 3 days ahead
  10. Relaunch app
  • Verified user will be prompted with rating modal when brave news is disabled.
  • Verified user rating card shows up in the brave news feed when opting in.
  • Verified user is able to submit rating feedback to app store.
  • Verified user is able to dismiss the user rating modal.

Encountered: #28315

Example Example Example Example Example
screenshot-1675702914533 screenshot-1675702923428 screenshot-1675703879751 screenshot-1675703930905 screenshot-1675703582656

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment