Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase target of draggable chrome #25757

Closed
mlntr opened this issue Oct 1, 2022 · 4 comments · Fixed by brave/brave-core#15523
Closed

Increase target of draggable chrome #25757

mlntr opened this issue Oct 1, 2022 · 4 comments · Fixed by brave/brave-core#15523

Comments

@mlntr
Copy link

mlntr commented Oct 1, 2022

Feature request

  • Brave has has this narrow address bar, so there is space on both sides:

image

  • This space could be made useful by letting users move the window position by dragging it

  • When the tab row is full, users have to be more careful to drag the window. This would help alleviate this while making use of unused space

  • Firefox and Safari have this same convenient feature

@rebron rebron added priority/P4 Planned work. We expect to get to it "soon". QA/Yes labels Oct 4, 2022
@rebron
Copy link
Collaborator

rebron commented Oct 4, 2022

cc: @simonhong what do you think?

@simonhong
Copy link
Member

cc: @simonhong what do you think?

I think this is good suggestion. empty toolbar area would be good place for dragging!

@mlntr
Copy link
Author

mlntr commented Nov 26, 2022

Now that it'll be possible to drag the chrome, the extra drag gap in the tab bar isn't so necessary.

Do you think it'd be worth eliminating that gap? Users would then be able to see more of the tabs' content because the tabs will be wider, making it easier recognise tabs (especially useful if many tabs from the same website/favicon)

image

Reason I can see not to would be if a user has the wide address bar setting on

@stephendonner
Copy link

Verified PASSED using

Brave 1.47.120 Chromium: 108.0.5359.99 (Official Build) dev (x86_64)
Revision 410951fc34bb4b2cbf182231f9f779efaafaf682-refs/branch-heads/5359_71@{#9}
OS macOS Version 13.1 (Build 22C65)

Steps:

  1. installed 1.47.120
  2. launched Brave
  3. left side: confirmed I could click + hold the empty toolbar area between the Reload this page and Bookmark this tab icons, to drag and reposition the browser
  4. right side: confirmed I could click + hold the empty toolbar area between the BAT/Rewards icon and the Show side panel button

Newly-draggable regions

left side right side full toolbar
Screenshot 2022-12-08 at 11 04 43 PM Screenshot 2022-12-08 at 11 04 51 PM Screenshot 2022-12-08 at 11 06 19 PM

@rebron rebron changed the title Draggable chrome Increase target of draggable chrome Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants