Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save custom background image in a directory #25553

Closed
sangwoo108 opened this issue Sep 22, 2022 · 2 comments · Fixed by brave/brave-core#15175
Closed

Save custom background image in a directory #25553

sangwoo108 opened this issue Sep 22, 2022 · 2 comments · Fixed by brave/brave-core#15175
Assignees
@sangwoo108
Labels
feature/new-tab OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/exclude
Milestone
1.46.x - Release

Comments

@sangwoo108
Copy link

subtask for #15252

In order to allow users to upload multiple images, we should save images into a directory.
Currently, we overwrite the image. (delete and save it with same name)
@sangwoo108 sangwoo108 added feature/new-tab priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude OS/Desktop labels Sep 22, 2022
@sangwoo108 sangwoo108 self-assigned this Sep 22, 2022
@sangwoo108 sangwoo108 mentioned this issue Sep 22, 2022
Merged
25 tasks
@sangwoo108 sangwoo108 added QA/Yes and removed QA/No labels Sep 22, 2022
@brave-builds brave-builds added this to the 1.46.x - Nightly milestone Sep 27, 2022
@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.46.81 Chromium: 107.0.5304.68 (Official Build) beta (64-bit)
-- | --
Revision | a4e93e89d3b3df1be22214603fba846ad0183ca5-refs/branch-heads/5304@{#991}
OS | Windows 11 Version 21H2 (Build 22000.1098)

Before Upgrade

  1. Install 1.45.113
  2. launch Brave
  3. open NTP
  4. click Customize
  5. click `Upload from device
  6. upload a custom image
  7. uploaded image is displayed as the background image
  8. close the browser
step 5 step 6 step 7a step 7b
image image image image

After Upgrade

  1. rename the profile
  2. Install 1.46.81
  3. launch brave profile
  4. confirmed image is retained from previous version
  5. click Customize
  6. click Upload from device and image is displayed as the thumbnail
  7. click Upload from device to upload couple of more images

Confirmed image is retained from previous version and able to upload multiple custom images

step 12 step 14 Ex1 Ex2 Ex3
image image image image image

@stephendonner
Copy link

stephendonner commented Oct 27, 2022 •
edited by btlechowski
Loading

Verified PASSED using

Before upgrade

  1. installed 1.45.113
  2. launched Brave
  3. opened NTP
  4. clicked Customize
  5. clicked `Upload from device
  6. uploaded a custom image
  7. uploaded image is displayed as the background image
  8. closed the browser

Screen Shot 2022-10-27 at 4 48 37 PM

After upgrade

  1. renamed the profile from Brave Browser -> Brave Browser Beta
  2. installed 1.46.81
  3. launched brave profile
  4. confirmed image is retained from previous version
  5. clicked Customize
  6. clicked Upload from device and image is displayed as the thumbnail
  7. clicked Upload from device to upload a couple more images

Confirmed the original image upload was retained, as well as subsequent image uploads

example example example example
Screen Shot 2022-10-27 at 4 49 57 PM Screen Shot 2022-10-27 at 4 50 26 PM Screen Shot 2022-10-27 at 4 50 40 PM Screen Shot 2022-10-27 at 4 50 55 PM

Verification passed on

Brave 1.46.117 Chromium: 107.0.5304.110 (Official Build) beta (64-bit)
Revision 2a558545ab7e6fb8177002bf44d4fc1717cb2998-refs/branch-heads/5304@{#1202}
OS Ubuntu 18.04 LTS

Before upgrade

  1. installed 1.45.113
  2. launched Brave
  3. opened NTP
  4. clicked Customize
  5. clicked `Upload from device
  6. uploaded a custom image
  7. uploaded image is displayed as the background image
  8. closed the browser

image
image

After upgrade

  1. renamed the profile from Brave Browser -> Brave Browser Beta
  2. installed 1.46.81
  3. launched brave profile
  4. confirmed image is retained from previous version
  5. clicked Customize
  6. clicked Upload from device and image is displayed as the thumbnail
  7. clicked Upload from device to upload a couple more images

Confirmed the original image upload was retained, as well as subsequent image uploads

image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sangwoo108 sangwoo108

Labels
feature/new-tab OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.46.x - Release
Development

Successfully merging a pull request may close this issue.

Save custom background image to a dedicated directory brave/brave-core
6 participants
@stephendonner @sangwoo108 @LaurenWags @btlechowski @brave-builds @MadhaviSeelam