Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move up toolbar next to caption buttons when vertical tab is being used #25473

Closed
Tracked by #23467
sangwoo108 opened this issue Sep 19, 2022 · 4 comments · Fixed by brave/brave-core#15523
Closed
Tracked by #23467

move up toolbar next to caption buttons when vertical tab is being used #25473

sangwoo108 opened this issue Sep 19, 2022 · 4 comments · Fixed by brave/brave-core#15523
Assignees
@sangwoo108
Labels
OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Milestone
1.47.x - Release

Comments

@sangwoo108
Copy link

sangwoo108 commented Sep 19, 2022 •
edited
Loading

Add a tab context menu to hide window title when vertical tab strip is enabled. When hiding window title, we can claim title area so that users can use taller contents area.

  • On Mac and Window, toolbar will take the title area.
  • On Linux, title area will be as short as possible
    • can't overlay caption buttons on toolbar for now.

Also, we should make it easy to move window when hiding window title as there's almost no non-client area. Thus, enable dragging windows by dragging toolbar area.
@sangwoo108 sangwoo108 mentioned this issue Sep 19, 2022
Closed
15 tasks
@sangwoo108 sangwoo108 self-assigned this Sep 19, 2022
@sangwoo108 sangwoo108 added priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude OS/Desktop labels Sep 19, 2022
@sangwoo108
Copy link
Author

Windows glass frame

no title

image

with title

image

@sangwoo108
Copy link
Author

Mac

With title

image

no title

image

@sangwoo108 sangwoo108 mentioned this issue Oct 19, 2022
Merged
25 tasks
@sangwoo108
Copy link
Author

Linux

With title

image

No title

image

@sangwoo108
Copy link
Author

Windows opaque frame

with title

image

no title

image

This was referenced Oct 25, 2022
Closed
Open
@sangwoo108 sangwoo108 added priority/P4 Planned work. We expect to get to it "soon". priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P3 The next thing for us to work on. It'll ride the trains. priority/P4 Planned work. We expect to get to it "soon". labels Oct 25, 2022
@brave-builds brave-builds added this to the 1.47.x - Nightly milestone Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sangwoo108 sangwoo108

Labels
OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Projects
None yet
Milestone
1.47.x - Release
Development

Successfully merging a pull request may close this issue.

Support hiding window title when using vertical tab strip brave/brave-core
2 participants
@sangwoo108 @brave-builds