Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update l10n for greaselion #25359

Closed
mkarolin opened this issue Sep 12, 2022 · 3 comments
Closed

Update l10n for greaselion #25359

mkarolin opened this issue Sep 12, 2022 · 3 comments
Assignees
@mkarolin
Labels
OS/Desktop QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
Greaselion 1.0.201

Comments

@mkarolin
Copy link
Contributor

Download the latest l10n from Transifex for Greaselion.

Test plan:
Spot check tip button hover text on tipping websites.
@mkarolin mkarolin added this to the Greaselion Next milestone Sep 12, 2022
@mkarolin mkarolin self-assigned this Sep 12, 2022
@mkarolin mkarolin mentioned this issue Sep 12, 2022
Merged
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Sep 22, 2022 •
edited
Loading

Verified using dev component for:

Brave Local Data Updater - Version: 1.0.649

Launched 1.44.95 using --use-dev-goupdater-url and ensured that the Send a tip hover text is translated in other locales

Germany Kannada France Hindi
image image image image

GH pages in Germany locale:
spot check on send a tip hover text translation in various GH pages

Example Example Example Example Example
image image image image image

@stephendonner
Copy link

stephendonner commented Sep 22, 2022 •
edited
Loading

Verified PASSED using

Brave 1.43.93 Chromium: 105.0.5195.127 (Official Build) (x86_64)
Revision 912488396852bf658ab32465980c0b93a3c27a83-refs/branch-heads/5195@{#1109}
OS macOS Version 11.7 (Build 20G817)
Russian Spanish Italian Korean
Снимок экрана 2022-09-22 в 9 42 38 AM Captura de pantalla 2022-09-22 a las 9 38 20 Schermata 2022-09-22 alle 9 47 48 AM 스크린샷 2022-09-22 오전 10 02 56

@mkarolin
Copy link
Contributor Author

mkarolin commented Sep 22, 2022 •
edited
Loading

Fixed via brave/brave-site-specific-scripts#86 (brave/brave-core-crx-packager#489)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkarolin mkarolin

Labels
OS/Desktop QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
Greaselion 1.0.201
Development

No branches or pull requests
3 participants
@stephendonner @GeetaSarvadnya @mkarolin