-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement "custodial connection unavailable" error modal #25125
Comments
@Miyayes Is it important that the custodian name appears in the modal title? We'd have to add new code to handle that, as we only expect to do substitutions in the body of the modal not the title. Not the end of the world if we have to add that, just figured I'd check! |
@emerick I'll edit to remove that. We'll just do substitution in the body. |
Verified with
Verified test plan from brave/brave-core#15627 for: Uphold - PASSEDLogs:
Confirmed error message displayed as expected.
bitFlyer - PASSEDLogs:
Confirmed error message displayed as expected.
Gemini - PASSEDLogs:
Confirmed error message displayed as expected.
|
Description
Server-side PR: brave-intl/bat-go#1574
Documentation: https://github.com/brave-intl/bat-go/pull/1576/files
The text was updated successfully, but these errors were encountered: