Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboarding: show import from legacy checkbox when 24 words are pasted #25045

Closed
josheleonard opened this issue Aug 29, 2022 · 2 comments · Fixed by brave/brave-core#14897
Closed
Assignees
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes onboarding Front-end related to helping a new user learn about features within the browser. OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include

Comments

@josheleonard
Copy link

Description

A checkbox should be shown on the "Import from seed phrase" Brave Wallet onboarding page. This will match the current iOS implementation. This will also ensure that the wallet is imported correctly.

Steps to Reproduce

  1. Start Wallet onboarding
  2. Select import
  3. Select import from seed phrase
  4. Enter a 24 recovery phrase

Actual result:

A "Import from legacy Brave crypto wallets" checkbox should be shown

Expected result:

No checkbox is shown, causing import errors

Reproduces how often:

Easy

Brave version (brave://version info)

1.45.5 Chromium: 105.0.5195.52 (Official Build) nightly (arm64)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the nightly channel? Yes
@josheleonard josheleonard self-assigned this Aug 29, 2022
@josheleonard josheleonard added QA/Yes release-notes/include onboarding Front-end related to helping a new user learn about features within the browser. front-end-change This task is a front end task and doesn't need any C++ changes labels Aug 29, 2022
@josheleonard josheleonard moved this to Done in Web3 Aug 31, 2022
@brave-builds brave-builds added this to the 1.45.x - Nightly milestone Aug 31, 2022
@kjozwiak kjozwiak added the feature/web3/wallet Integrating Ethereum+ wallet support label Sep 7, 2022
@kjozwiak
Copy link
Member

kjozwiak commented Sep 7, 2022

The above requires 1.44.77 or higher for 1.44.x verification 👍

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.44.86 Chromium: 105.0.5195.127 (Official Build) beta (64-bit)
Revision 912488396852bf658ab32465980c0b93a3c27a83-refs/branch-heads/5195@{#1109}
OS Linux
  • Verified steps from brave/brave-core#14897
  • Verified when 24-word seed is used, shows message to import from legacy wallet
  • Verified when an extra word is added to 24-word seed phrase shows the error message
  • Verified able to import wallet from 24 word seed
    image

Verification passed on

Brave 1.44.86 Chromium: 105.0.5195.127 (Official Build) beta (64-bit)
Revision 912488396852bf658ab32465980c0b93a3c27a83-refs/branch-heads/5195@{#1109}
OS Windows 11 Version 21H2 (Build 22000.795)
  • Verified steps from brave/brave-core#14897
  • Verified when 24-word seed is used, shows message to import from legacy wallet
  • Verified when an extra word is added to 24-word seed phrase shows the error message
  • Verified able to import wallet from 24 word seed
    image

Verification passed on

Brave 1.44.86 Chromium: 105.0.5195.127 (Official Build) beta (arm64)
Revision 912488396852bf658ab32465980c0b93a3c27a83-refs/branch-heads/5195@{#1109}
OS macOS Version 12.4 (Build 21F79)
  • Verified steps from brave/brave-core#14897
  • Verified when 24-word seed is used, shows message to import from legacy wallet
  • Verified when an extra word is added to 24-word seed phrase shows the error message
  • Verified able to import wallet from 24 word seed
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes onboarding Front-end related to helping a new user learn about features within the browser. OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants