Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Contact Support" from adaptive captcha doesn't work with WebUI rewards panel #24846

Closed
LaurenWags opened this issue Aug 22, 2022 · 5 comments · Fixed by brave/brave-core#14738

Comments

@LaurenWags
Copy link
Member

Description

Found while testing #22423

When Rewards WebUI panel is enabled, the "Contact support" button doesn't open the Brave Help Center in a new tab. This works as expected when Rewards WebUI panel is not enabled.

Steps to Reproduce

  1. Clean profile 1.43.x, staging env
  2. Relaunch browser so that griffin seed is pulled and BraveRewardsWebUiPanelStudy:Enabled is shown on brave://version
  3. Enable Rewards
  4. View an ad
  5. Schedule an adaptive captcha
  6. Trigger adaptive captcha
  7. Fail solving captcha w/ max attempts
  8. Click on "Contact support" button

Actual result:

Brave Help Center does not open in a new tab after clicking "Contact support" below.

Screen Shot 2022-08-22 at 9 10 01 AM

Expected result:

Brave Help Center should open in a new tab

Reproduces how often:

easily

Brave version (brave://version info)

Brave | 1.43.74 Chromium: 104.0.5112.102 (Official Build) beta (x86_64)
-- | --
Revision | 8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478}
OS | macOS Version 12.5.1 (Build 21G83)

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a (works fine without webUI panel enabled)
  • Can you reproduce this issue with the beta channel? yes 1.43.x
  • Can you reproduce this issue with the nightly channel? yes 1.44.x

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @Miyayes @zenparsing @rebron

@LaurenWags
Copy link
Member Author

Adding QA/Blocked until this is uplifted to 1.43.x

@GeetaSarvadnya
Copy link

Reproduced the issue in Windows 10 x64

Brave 1.43.78 Chromium: 104.0.5112.102 (Official Build) beta (64-bit)
Revision 8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478}
OS Windows 10 Version 21H2 (Build 19044.1889)

@kjozwiak
Copy link
Member

The above will require 1.43.81 or higher for 1.43.x verification 👍

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Aug 26, 2022

Verification PASSED on

Brave | 1.43.82 Chromium: 105.0.5195.58 (Official Build) (64-bit)
-- | --
Revision | 1907e1693887af4463221a10247360b7a056db49-refs/branch-heads/5195_47@{#3}
OS | Windows 10 Version 21H2 (Build 19044.1889)

  • The griffin study BraveRewardsWebUiPanelStudy:Enabled is not been added in RC hence I was not able to see this study in brave://version. Verified the issue by enabling/disabling the flag #brave-rewards-webui-panel via brave://flags

  • Ensured that click on Contact support opens up the Brave Help Center in a new tab in both webui-panel enable and disable conditions

#brave-rewards-webui-panel - Enabled

Example Example Example
image image image

#brave-rewards-webui-panel - Disabled

Example Example Example
image image image

@LaurenWags
Copy link
Member Author

LaurenWags commented Aug 26, 2022

Verified with

Brave | 1.43.81 Chromium: 104.0.5112.102 (Official Build) (x86_64)
-- | --
Revision | 8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478}
OS | macOS Version 12.5.1 (Build 21G83)

Verified STR from description with brave://flags/#brave-rewards-webui-panel manually enabled since Griffin study is not in Release channel yet.
Confirmed clicking on "Contact support" opens Brave Help Center in a new tab.

Example Example
Screen Shot 2022-08-26 at 11 38 16 AM Screen Shot 2022-08-26 at 11 38 25 AM

Verified STR from description with brave://flags/#brave-rewards-webui-panel manually disabled (default state).
Confirmed clicking on "Contact support" still opens Brave Help Center in a new tab.

Example Example
Screen Shot 2022-08-26 at 11 43 23 AM Screen Shot 2022-08-26 at 11 43 43 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants