Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove whitespaces when pasting contract address for adding a custom token #24728

Closed
srirambv opened this issue Aug 17, 2022 · 1 comment · Fixed by brave/brave-core#14684
Closed
Assignees
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include

Comments

@srirambv
Copy link
Contributor

Description

Ran in to #24721 while adding an ERC721 token on Android. When copy pasting the contract address, the cursor position doesn't clearly shows an extra space at the end which can be easily missed and can lead to issues like #24721. It would be nice to remove any whitespace when pasting the contract address

Steps to reproduce

  1. Add a contract address on Slack
  2. Copy contract address from Slack and try to add it
  3. Autofills the contract details but doesn't add the token because there is a whitespace at the end of contract address

Actual result

Unable to add ERC721 token when there is a whitespace at the end of paste

Expected result

Remove whitespaces when pasting contract address for adding a custom token

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Yes
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): All
  • Android version: 12

Brave version

All

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards?NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @Pavneet-Sing @SergeyZhukovsky @wchen342

@srirambv srirambv added QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Aug 17, 2022
@srirambv srirambv added this to Web3 Aug 17, 2022
@Pavneet-Sing Pavneet-Sing self-assigned this Aug 17, 2022
@Pavneet-Sing Pavneet-Sing moved this to In Progress in Web3 Aug 17, 2022
Repository owner moved this from In Progress to Done in Web3 Aug 18, 2022
@brave-builds brave-builds added this to the 1.44.x - Nightly milestone Aug 18, 2022
@srirambv
Copy link
Contributor Author

srirambv commented Sep 6, 2022

Verification passed on the following devices running 1.44.75 x64 Beta build

  • Verified steps from issue description
  • Verified able to add custom token when pasting contract address from clipboard
Oppo Reno (Android 12) Samsung Tab A (Android 10)
24728-ARM.mp4
24728-Tab.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants