Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave translate bubble is not shown when clicked browser back button #24714

Open
MadhaviSeelam opened this issue Aug 17, 2022 · 1 comment
Open

Comments

@MadhaviSeelam
Copy link

Description

Steps to Reproduce

  1. Install 1.43.67
  2. launch Brave
  3. restart the browser to enable Brave translate via griffin
  4. visit a French language site https://www.lemonde.fr/
  5. brave translate bubble is shown
  6. click on a link
  7. Brave translate bubble is shown
  8. click back button

Actual result:

Brave translate bubble is not shown.
Brave translate bubble shows up when page is reloaded

2022-08-16_17h44_58.mp4

Expected

result:
Brave translate bubble should show up when clicked back button

Reproduces how often:

Easily

Brave version (brave://version info)

Brave 1.43.67 Chromium: 104.0.5112.81 (Official Build) beta (64-bit)
Revision 5b7b76419d50f583022568b6764b630f6ddc9208-refs/branch-heads/5112@{#1309}
OS Windows 11 Version 21H2 (Build 22000.856)

Version/Channel Information:

  • Can you reproduce this issue with the current release? N/A
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? N/A

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@rebron @stephendonner

@atuchin-m
Copy link
Contributor

It seems that problem happens when the back-forward cache is used for a navigation.
The problem also could be reproduced in Chrome with uBlock (because some ads JavaScript suppresses using bf cache).

cc @rebron

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants