Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tip button placement on Twitter incorrect again #24710

Closed
LaurenWags opened this issue Aug 16, 2022 · 4 comments
Closed

Tip button placement on Twitter incorrect again #24710

LaurenWags opened this issue Aug 16, 2022 · 4 comments

Comments

@LaurenWags
Copy link
Member

Description

Tip button placement was adjusted in last GL update via #24134

It is now showing incorrectly again. Example link:

https://twitter.com/brendaneich/status/1559579029144887296

Reported by @szilardszaloki via https://bravesoftware.slack.com/archives/C01F09348SV/p1660668967984699

Steps to Reproduce

  1. Navigate to link
  2. See incorrect Tip button placement

Actual result:

Screen Shot 2022-08-16 at 1 22 04 PM

Expected result:

Should be like other tip buttons in above screenshot

Reproduces how often:

easily

Brave version (brave://version info)

1.43.x, Brave Local Data Updater version 1.0.180

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @emerick @Miyayes

@Miyayes Miyayes added priority/P2 A bad problem. We might uplift this to the next planned release. greaselion/twitter labels Aug 18, 2022
@LaurenWags
Copy link
Member Author

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Sep 22, 2022

Verified using dev component for:

Brave Local Data Updater - Version: 1.0.649

Reproduced the issue with the component 1.0.199
image

Launched 1.44.95 using --use-dev-goupdater-url and ensured issue is fixed with the component 1.0.649 and ensured that the tip button is aligned with action button on twitter posts
image

image
Verified the reddit posts and ensured that the tip button is aligned with action button on reddit posts
https://www.reddit.com/r/brave_browser/comments/vxelra/new_today_in_brave_v141_solana_dapp_support_for/

@stephendonner
Copy link

Verified PASSED using

Brave 1.43.93 Chromium: 105.0.5195.127 (Official Build) (x86_64)
Revision 912488396852bf658ab32465980c0b93a3c27a83-refs/branch-heads/5195@{#1109}
OS macOS Version 11.7 (Build 20G817)

Confirmed new working component version 1.0.649:

Screen Shot 2022-09-22 at 8 53 24 AM

Confirmed Tip button placement and functionality

https://twitter.com/brendaneich/status/1559579029144887296:

example example
Screen Shot 2022-09-22 at 9 16 55 AM Screen Shot 2022-09-22 at 9 17 00 AM

https://www.reddit.com/r/brave_browser/comments/vxelra/new_today_in_brave_v141_solana_dapp_support_for/:

example example
Screen Shot 2022-09-22 at 9 17 47 AM Screen Shot 2022-09-22 at 9 17 55 AM

@mkarolin
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants