Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

panopticlick reports unique-ish fingerprint for brave even with FP turned on #2469

Closed
diracdeltas opened this issue Dec 11, 2018 · 7 comments
Assignees
Labels
closed/invalid needs-investigation A bug not 100% confirmed/fixed priority/P2 A bad problem. We might uplift this to the next planned release. privacy/tracking Preventing sites from tracking users across the web privacy

Comments

@diracdeltas
Copy link
Member

diracdeltas commented Dec 11, 2018

in browser-laptop, panopticlick used to always reported the same value for canvas fingerprint across all instances of Brave.

in brave-core, it appears to be showing unique-ish values depending on the computer that is being used for testing.

either panopticlick/fingerprint2.js has improved or we have regressed

STR:

  1. go to https://panopticlick.eff.org/ with fingerprinting protection set to block all
  2. test your browser
  3. note the canvas fingerprinting result
  4. repeat 1-3 on a different computer
  5. it should have the same result
@diracdeltas diracdeltas added priority/P2 A bad problem. We might uplift this to the next planned release. privacy/tracking Preventing sites from tracking users across the web labels Dec 11, 2018
@diracdeltas
Copy link
Member Author

needs investigation. seems that internally most (but not all?) of us get cf04c1dcb26ef79705764e5c22d0e711 as the canvas hash value

@diracdeltas diracdeltas added the needs-investigation A bug not 100% confirmed/fixed label Dec 11, 2018
@ghost
Copy link

ghost commented Dec 11, 2018

Panopticlick uses https://valve.github.io/fingerprintjs2/ for JS fingerprinting. That page (consistently) shows 2fc01ae532f967b3bda3b42520cfb824 as my FP, with FP protection set to block all. Note that you might need to disable ad & tracker blocking for the JS file to load (due to its name).

(I use version 0.56.15)

@pes10k
Copy link
Contributor

pes10k commented Dec 11, 2018

@Shifterovich what value do you get for https://panopticlick.eff.org/ with FP protection on?

@ghost
Copy link

ghost commented Dec 11, 2018

Canvas FP? cf04c1dcb26ef79705764e5c22d0e711.

Is the idea that FP protection should only make sure the canvas FP is the same, or should also the FP calculated like this https://valve.github.io/fingerprintjs2/ be the same?

@pes10k
Copy link
Contributor

pes10k commented Dec 11, 2018

For this issue / at the moment, just trying to make sure EFF reports the same value. FP2 considers a wider range of values. Once we're sure everyone looks the same on Panopticlick, will tackle FP2.js, as reported by https://valve.github.io/fingerprintjs2/

@ghost
Copy link

ghost commented Dec 11, 2018

BTW is that FP Brave-specific or is it more generic? Identifying the browser as Brave using that FP is not wanted.

Once we're sure everyone looks the same on Panopticlick, will tackle FP2.js

Again, note that Panopticlick uses FP2.js. Almost ideal case scenario is that the combination of all those values is consistent on all Brave instances. Ideal case scenario is that the combination wouldn't be Brave-specific to not allow identifying to browser as Brave.

Identifying the browser as Brave is not an issue when a large enough userbase is reached, like Tor has.

@pes10k
Copy link
Contributor

pes10k commented Dec 11, 2018

@Shifterovich the diff is that the FP reported by EFF is just the Canvas FP, which is just one input to the browser fingerprint generated by FP2.js. Having identical FP2.js browser fingerprints is the ideal, but difficult (maybe impossible) because of hard-to-fake attributes (view port dimensions, color depth, etc). But, working to get as close as possible.

Closing this issue Since EFF is reporting identical canvas FPs. Will open another issue trying to nail down FP2.js differences

@pes10k pes10k closed this as completed Dec 11, 2018
@bbondy bbondy added this to the Dupe / Invalid / Not actionable milestone Dec 18, 2018
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/invalid needs-investigation A bug not 100% confirmed/fixed priority/P2 A bad problem. We might uplift this to the next planned release. privacy/tracking Preventing sites from tracking users across the web privacy
Projects
None yet
Development

No branches or pull requests

4 participants