No internet connection modal is not shown when setting up sync after being offline

[btlechowski]

Steps to Reproduce

1. Clean install
2. Go offline (unplug internet connection from router or disconnect wifi)
3. Open chrome://bravesync/ and chose I am new to Sync
4. Click Set up Sync
5. Go online and wait X minutes (waited for over an hour; TODO determine X)

Actual result:

Device list is empty
No retry is made
Reload does not help
Note: Closing and opening Brave will fix the issue

Expected result:

No internet connection modal

Reproduces how often:

always

Brave version (brave://version info)

Brave	0.58.11 Chromium: 71.0.3578.80 (Official Build) beta (64-bit)
Revision	2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS	Windows 7 x64

Also reproducible on Windows 10 x64, when internet connection is unplugged from router
When I turn off wifi on Window 10, I get No internet connection modal.

cc @darkdh @kjozwiak @LaurenWags @srirambv @GeetaSarvadnya

[LaurenWags]

Did not reproduce on macOS for me, I got an (expected) error message at step 4 when trying to 'Set up Sync' after wifi has been turned off.

Brave	0.58.11 Chromium: 71.0.3578.80 (Official Build) beta(64-bit)
Revision	2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS	Mac OS X

[srirambv]

Cant reproduce on Linux. Here's what i tried

• Disconnect network
• Try creating sync chain, shows appropriate error message No internet connection
• Bring device back online
• Dismiss error message and click Setup Sync
• Creates sync chain and device name shows up within 5 seconds

[cezaraugusto]

@btlechowski could you please check again and see if issue persists?

[btlechowski]

Does not reproduce in:

Brave	0.59.20 Chromium: 72.0.3626.28 (Official Build) beta (64-bit)
Revision	997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS	Windows 7