-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOH Ipfs override may cause high cpu usage #24461
Labels
feature/web3/ipfs
OS/Android
Fixes related to Android browser functionality
OS/Desktop
priority/P2
A bad problem. We might uplift this to the next planned release.
QA Pass - Android ARM
QA Pass-macOS
QA/Yes
release-notes/include
Milestone
Comments
cypt4
added
OS/Android
Fixes related to Android browser functionality
OS/Desktop
priority/P2
A bad problem. We might uplift this to the next planned release.
labels
Aug 5, 2022
cypt4
added a commit
to brave/brave-core
that referenced
this issue
Aug 8, 2022
Resolves brave/brave-browser#24461 This should lower CPU usage in case the network service fails to start.
cypt4
added a commit
to brave/brave-core
that referenced
this issue
Aug 12, 2022
Resolves brave/brave-browser#24461 This should lower CPU usage in case the network service fails to start.
7 tasks
The above will require |
Verification
|
Brave | 1.43.81 Chromium: 104.0.5112.102 (Official Build) (x86_64) |
---|---|
Revision | 8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478} |
OS | macOS Version 13.0 (Build 22A5321d) |
Steps:
- installed
1.43.81
- launched Brave
- loaded
brave://ipfs-internals
- clicked on
Install and start
- opened
Window
->Task Manager
- selected
Utility: Network Service
- clicked on
End Process
- opened
brave://settings/security
and made sureWith Cloudflare (1.1.1.1)
was selected - loaded
ipns://en.wikipedia-on-ipfs.org
Confirmed it loaded ipns://en.wikipedia-on-ipfs.org/wiki/
with a new Utility: Network Service
process (Old: 4163
, New: 4314
)
example | example | example | example |
---|---|---|---|
Verified
|
DoH setting | ipfs://...van_Gogh.html |
ipfs://...55fbzdi/ |
ipns://brad.crypto |
ipns://ipfs.io |
---|---|---|---|---|
Ran through https://github.com/brave/qa-resources/blob/82e6e8dd508f87595b20c4bbde093cd80d124dbe/wikitemplate-IPFS.md#ipfs-on-android
, additionally 👍
Logged #25103.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature/web3/ipfs
OS/Android
Fixes related to Android browser functionality
OS/Desktop
priority/P2
A bad problem. We might uplift this to the next planned release.
QA Pass - Android ARM
QA Pass-macOS
QA/Yes
release-notes/include
There is a report from @aseren where he got high cpu usage on macos when closed the browser.
Sampling pointed to the doh override network service listener. Seems network service was down and didn't wake up.
So throttling needed when try to reconnect to network manager.
The text was updated successfully, but these errors were encountered: