Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOH Ipfs override may cause high cpu usage #24461

Closed
cypt4 opened this issue Aug 5, 2022 · 3 comments · Fixed by brave/brave-core#14510
Closed

DOH Ipfs override may cause high cpu usage #24461

cypt4 opened this issue Aug 5, 2022 · 3 comments · Fixed by brave/brave-core#14510
Assignees
Labels
feature/web3/ipfs OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass-macOS QA/Yes release-notes/include

Comments

@cypt4
Copy link

cypt4 commented Aug 5, 2022

There is a report from @aseren where he got high cpu usage on macos when closed the browser.
Sampling pointed to the doh override network service listener. Seems network service was down and didn't wake up.
So throttling needed when try to reconnect to network manager.

@cypt4 cypt4 added OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. labels Aug 5, 2022
@cypt4 cypt4 added this to the 1.43.x - Beta milestone Aug 5, 2022
@cypt4 cypt4 self-assigned this Aug 5, 2022
cypt4 added a commit to brave/brave-core that referenced this issue Aug 8, 2022
Resolves brave/brave-browser#24461
This should lower CPU usage in case the network service fails to start.
cypt4 added a commit to brave/brave-core that referenced this issue Aug 12, 2022
Resolves brave/brave-browser#24461
This should lower CPU usage in case the network service fails to start.
@kjozwiak
Copy link
Member

The above will require 1.43.81 or higher for 1.43.x verification.

@stephendonner
Copy link

stephendonner commented Aug 24, 2022

Verification PASSED using

Brave 1.43.81 Chromium: 104.0.5112.102 (Official Build) (x86_64)
Revision 8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478}
OS macOS Version 13.0 (Build 22A5321d)

Steps:

  1. installed 1.43.81
  2. launched Brave
  3. loaded brave://ipfs-internals
  4. clicked on Install and start
  5. opened Window -> Task Manager
  6. selected Utility: Network Service
  7. clicked on End Process
  8. opened brave://settings/security and made sure With Cloudflare (1.1.1.1) was selected
  9. loaded ipns://en.wikipedia-on-ipfs.org

Confirmed it loaded ipns://en.wikipedia-on-ipfs.org/wiki/ with a new Utility: Network Service process (Old: 4163, New: 4314)

example example example example
Screenshot 2022-08-24 at 3 32 45 PM Screenshot 2022-08-24 at 3 33 15 PM Screenshot 2022-08-24 at 3 33 41 PM Screenshot 2022-08-24 at 3 34 12 PM

@stephendonner
Copy link

stephendonner commented Aug 31, 2022

Verified PASSED using

Brave 1.43.86, Chromium 105.0.5195.68 running Android 9 on a Google Pixel XL.

Confirmed no crashes, and (apart from the occasional HTTP 504 from the servers), I could load all the pages.

Steps:

  1. installed 1.43.86
  2. launched Brave
  3. set OpenDNS for Choose another provider, in Settings -> Brave Shields & privacy -> Use secure DNS
  4. loaded sample test sites

Ran through the following URLs:

  • ipfs://bafybeiemxf5abjwjbikoz4mc3a3dla6ual3jsgpdr4cjr3oz3evfyavhwq/wiki/Vincent_van_Gogh.html
  • ipfs://bafybeigdyrzt5sfp7udm7hu76uh7y26nf3efuylqabf3oclgtqy55fbzdi/
  • ipns://brad.crypto
  • ipns://ipfs.io
DoH setting ipfs://...van_Gogh.html ipfs://...55fbzdi/ ipns://brad.crypto ipns://ipfs.io
Screenshot_20220831-094414 Screenshot_20220831-092213 Screenshot_20220831-092019 Screenshot_20220831-091730 Screenshot_20220831-092355

Ran through https://github.com/brave/qa-resources/blob/82e6e8dd508f87595b20c4bbde093cd80d124dbe/wikitemplate-IPFS.md#ipfs-on-android, additionally 👍

Logged #25103.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/ipfs OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass-macOS QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants