Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitespace is not collapsed at the top of the page when nytimes.com site is loaded #24398

Closed
MadhaviSeelam opened this issue Aug 2, 2022 · 8 comments
Labels
bug closed/by-author feature/shields/adblock Blocking ads & trackers with Shields OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA/Yes release-notes/exclude

Comments

@MadhaviSeelam
Copy link

MadhaviSeelam commented Aug 2, 2022

Description

Steps to Reproduce

  1. Install 1.42.85
  2. visit nytimes.com in NTP

Actual result:

White space is displayed at the top of the page in both default & aggressive shields settings

default aggressive
image image

Expected result:

White space should collapse

Reproduces how often:

Easily

Brave version (brave://version info)

Brave 1.42.85 Chromium: 104.0.5112.81 (Official Build) (64-bit)
Revision 5b7b76419d50f583022568b6764b630f6ddc9208-refs/branch-heads/5112@{#1309}
OS Windows 11 Version 21H2 (Build 22000.795)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? No

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc: @rebron

@MadhaviSeelam MadhaviSeelam changed the title Blank space is not collapsed at the top of the page when nytimes.com site is loaded White space is not collapsed at the top of the page when nytimes.com site is loaded Aug 3, 2022
@rebron
Copy link
Collaborator

rebron commented Aug 9, 2022

cc: @ryanbr @antonok-edm

@ryanbr
Copy link

ryanbr commented Aug 10, 2022

Lets see how this goes: easylist/easylist@874f1fc

Give it 24hrs and retest. If that fails, set sheilds = Aggressive @MadhaviSeelam

@ryanbr
Copy link

ryanbr commented Aug 13, 2022

@MadhaviSeelam how is it looking? Just tested, the top ad header briefly shows before collapsing from what I'm seeing

@MadhaviSeelam MadhaviSeelam changed the title White space is not collapsed at the top of the page when nytimes.com site is loaded Whitespace is not collapsed at the top of the page when nytimes.com site is loaded Aug 15, 2022
@MadhaviSeelam
Copy link
Author

@ryanbr White space collapsed with Aggressive shields setting. Didn't collapse in default setting.

@rebron rebron added the feature/shields/adblock Blocking ads & trackers with Shields label Aug 19, 2022
@rebron
Copy link
Collaborator

rebron commented Aug 30, 2022

@MadhaviSeelam Should we close this one out as fixed or should we consider removing white space for the default setting?

@rebron rebron added priority/P4 Planned work. We expect to get to it "soon". QA/Yes release-notes/exclude labels Aug 30, 2022
@rebron
Copy link
Collaborator

rebron commented Aug 31, 2022

@ryanbr Any chance we can get hide as part of default shields setting?

@ryanbr
Copy link

ryanbr commented Sep 1, 2022

Looks okay currently @rebron . Is this working for you @MadhaviSeelam ?

nytimes-test

@MadhaviSeelam
Copy link
Author

Awesome & thanks @ryanbr. White space no longer displayed with default shields setting. Closing the issue.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug closed/by-author feature/shields/adblock Blocking ads & trackers with Shields OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA/Yes release-notes/exclude
Projects
None yet
Development

No branches or pull requests

3 participants