-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Whitespace is not collapsed at the top of the page when nytimes.com site is loaded #24398
Comments
cc: @ryanbr @antonok-edm |
Lets see how this goes: easylist/easylist@874f1fc Give it 24hrs and retest. If that fails, set sheilds = Aggressive @MadhaviSeelam |
@MadhaviSeelam how is it looking? Just tested, the top ad header briefly shows before collapsing from what I'm seeing |
@ryanbr White space collapsed with Aggressive shields setting. Didn't collapse in default setting. |
@MadhaviSeelam Should we close this one out as fixed or should we consider removing white space for the default setting? |
@ryanbr Any chance we can get hide as part of default shields setting? |
Looks okay currently @rebron . Is this working for you @MadhaviSeelam ? |
Awesome & thanks @ryanbr. White space no longer displayed with default shields setting. Closing the issue. |
Description
Steps to Reproduce
Actual result:
White space is displayed at the top of the page in both default & aggressive shields settings
Expected result:
White space should collapse
Reproduces how often:
Easily
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
cc: @rebron
The text was updated successfully, but these errors were encountered: