Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Sadly, no tokens yet" after importing wallet with non-zero balance - Follow up to 2260 #2379

Closed
LaurenWags opened this issue Dec 5, 2018 · 3 comments

Comments

@LaurenWags
Copy link
Member

Description

Follow up issue to #2260

After importing a funded Brave Payments wallet into Brave Rewards, the Rewards Settings page shows the correct non-zero balance for the wallet, but continues to show the "Sadly, no tokens yet" sidebar. This is confusing because it contradicts the existence of the tokens from the imported wallet, which are reflected in the displayed non-zero wallet balance.

Test plan / Steps to Reproduce

  1. Import Muon/Brave Payments wallet into b-c/Brave Rewards (detailed test plan in Import Brave Payments data from Muon brave-core#736).
  2. Click Brave Rewards icon in address bar, then Rewards Settings in the dropdown.

Actual result:

screen shot 2018-11-27 at 2 24 57 pm

Expected result:

If the wallet balance is zero, the sidebar should not say "no tokens yet."

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 0.57.17 Chromium: 71.0.3578.80 (Official Build) (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Mac OS X

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    Yes
@LaurenWags
Copy link
Member Author

cc @rebron as original issue was slated for 0.57.x

@mandar-brave mandar-brave added the priority/P2 A bad problem. We might uplift this to the next planned release. label Dec 14, 2018
@NejcZdovc NejcZdovc modified the milestones: 1.x Backlog, 0.58.x - Release Dec 17, 2018
@NejcZdovc NejcZdovc self-assigned this Dec 17, 2018
@NejcZdovc
Copy link
Contributor

should be fixed with brave/brave-core#1075

@LaurenWags
Copy link
Member Author

LaurenWags commented Dec 17, 2018

Verified passed with

Brave 0.58.14 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Mac OS X

Verification passed on

Brave 0.58.14 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Windows 7

image

Verification PASSED on Ubuntu 18.04.1 x64 using the following build:

Brave 0.58.14 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Linux

screen shot 2018-12-17 at 11 07 17 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants