Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add network filter to Visible Asset Modal #23675

Closed
Douglashdaniel opened this issue Jun 24, 2022 · 1 comment · Fixed by brave/brave-core#15519
Closed

Add network filter to Visible Asset Modal #23675

Douglashdaniel opened this issue Jun 24, 2022 · 1 comment · Fixed by brave/brave-core#15519
Assignees
@Douglashdaniel
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.47.x - Release

Comments

@Douglashdaniel
Copy link

Description

Add a Network filter to the Edit Visible Assets modal to allow sorting assets by network.

Screen Shot 2022-06-24 at 10 10 16 AM
@Douglashdaniel Douglashdaniel added feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Jun 24, 2022
@Douglashdaniel Douglashdaniel self-assigned this Jun 24, 2022
@Douglashdaniel Douglashdaniel moved this to Backlog in Web3 Jun 24, 2022
@Douglashdaniel Douglashdaniel moved this from Backlog to In Progress in Web3 Oct 5, 2022
@Douglashdaniel Douglashdaniel mentioned this issue Oct 18, 2022
Merged
25 tasks
@Douglashdaniel Douglashdaniel moved this from In Progress to In Review in Web3 Oct 18, 2022
Repository owner moved this from In Review to Done in Web3 Oct 21, 2022
@brave-builds brave-builds added this to the 1.47.x - Nightly milestone Oct 21, 2022
@srirambv
Copy link
Contributor

srirambv commented Nov 8, 2022

Verification passed on

Brave 1.47.46 Chromium: 107.0.5304.91 (Official Build) nightly (64-bit)
Revision 3d5948960d62418160796d5831a4d2d7d6c90fa8-refs/branch-heads/5304@{#1097}
OS Linux
  • Verified steps from brave/brave-core#15519
  • Verified network filter is available on Visible asset modal
  • Verified able to search tokens based on network or all network
  • Verified able to add tokens for specific network and lists in portfolio
23675.mp4

Verification passed on

Brave 1.47.46 Chromium: 107.0.5304.91 (Official Build) nightly (64-bit)
Revision 3d5948960d62418160796d5831a4d2d7d6c90fa8-refs/branch-heads/5304@{#1097}
OS Windows 11 Version 22H2 (Build 22621.755)
  • Verified steps from brave/brave-core#15519
  • Verified network filter is available on Visible asset modal
  • Verified able to search tokens based on network or all network
  • Verified able to add tokens for specific network and lists in portfolio
23675.mp4

Verification passed on

Brave 1.47.46 Chromium: 107.0.5304.91 (Official Build) nightly (64-bit)
Revision 3d5948960d62418160796d5831a4d2d7d6c90fa8-refs/branch-heads/5304@{#1097}
OS macOS Version 13.0 (Build 22A380)
  • Verified steps from brave/brave-core#15519
  • Verified network filter is available on Visible asset modal
  • Verified able to search tokens based on network or all network
  • Verified able to add tokens for specific network and lists in portfolio
23675.mov

@LaurenWags LaurenWags mentioned this issue Jan 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.47.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): Edit Visible Assets Network Selector brave/brave-core
3 participants
@srirambv @Douglashdaniel @brave-builds