Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dismiss Panel UI after Rejecting Transaction #23673

Closed
Douglashdaniel opened this issue Jun 24, 2022 · 1 comment · Fixed by brave/brave-core#16625
Closed

Dismiss Panel UI after Rejecting Transaction #23673

Douglashdaniel opened this issue Jun 24, 2022 · 1 comment · Fixed by brave/brave-core#16625
Assignees
@Douglashdaniel
Labels
feature/web3/wallet/solana feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes regression release-notes/include
Milestone
1.49.x - Release

Comments

@Douglashdaniel
Copy link

Description

After rejecting a Transactions the Main Panel UI should be dismissed.

Screen.Recording.2022-06-24.at.8.59.40.AM.mov
@Douglashdaniel Douglashdaniel moved this to Backlog in Web3 Jun 24, 2022
@Douglashdaniel Douglashdaniel self-assigned this Jun 24, 2022
@Douglashdaniel Douglashdaniel moved this from Backlog to In Progress in Web3 Jun 24, 2022
@Douglashdaniel Douglashdaniel mentioned this issue Jan 11, 2023
Merged
25 tasks
@Douglashdaniel Douglashdaniel moved this from In Progress to In Review in Web3 Jan 11, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Jan 12, 2023
@brave-builds brave-builds added this to the 1.49.x - Nightly milestone Jan 12, 2023
@LaurenWags LaurenWags added the feature/web3/wallet Integrating Ethereum+ wallet support label Feb 10, 2023
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.49.108 Chromium: 110.0.5481.104 (Official Build) beta (64-bit)
Revision 46de4a7f41979e829b430bc1ee30ef483aa227ac-refs/branch-heads/5481_77@{#19}
OS Linux
  • Verified steps from brave/brave-core#16625
  • Verified rejecting a transaction automatically dismisses the panel
23673.mp4

Verification passed on

Brave 1.49.108 Chromium: 110.0.5481.104 (Official Build) beta (64-bit)
Revision 46de4a7f41979e829b430bc1ee30ef483aa227ac-refs/branch-heads/5481_77@{#19}
OS Windows 11 Version 22H2 (Build 22621.755)
  • Verified steps from brave/brave-core#16625
  • Verified rejecting a transaction automatically dismisses the panel
23673.mp4

Verification passed on

Brave 1.49.108 Chromium: 110.0.5481.104 (Official Build) beta (arm64)
Revision 46de4a7f41979e829b430bc1ee30ef483aa227ac-refs/branch-heads/5481_77@{#19}
OS macOS Version 13.0 (Build 22A380)
  • Verified steps from brave/brave-core#16625
  • Verified rejecting a transaction automatically dismisses the panel
23672.mov

@LaurenWags LaurenWags mentioned this issue Mar 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
feature/web3/wallet/solana feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes regression release-notes/include
Projects
Web3
Archived in project
Milestone
1.49.x - Release
Development

Successfully merging a pull request may close this issue.

fix(wallet): Dismiss Panel UI After Reject brave/brave-core
4 participants
@srirambv @LaurenWags @Douglashdaniel @brave-builds