Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to complete Moonbeam transactions (Gas estimation fails) #23529

Closed
josheleonard opened this issue Jun 16, 2022 · 6 comments · Fixed by brave/brave-core#14088
Closed

Unable to complete Moonbeam transactions (Gas estimation fails) #23529

josheleonard opened this issue Jun 16, 2022 · 6 comments · Fixed by brave/brave-core#14088

Comments

@josheleonard
Copy link

Description

Reported via Brave community: https://community.brave.com/t/cannot-transfer-glmr-token-out-from-my-brave-wallet/379404

Steps to Reproduce

  1. Create a Brave Wallet
  2. Add Moonbeam via chainlist.org
  3. Fund account with GLMR - faucet: https://glmr.supply/
  4. Attempt to send GLMR

Actual result:

Confirmation panel never opens, console logs err=Failed to get the gas fees for EIP-1559 transaction

Expected result:

Confirmation panel opens, transaction completes after signing

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

1.39.120 Chromium: 102.0.5005.99 (Official Build) (arm64)
870f7bcc58dfa811cc68c2186439721385e086d0-refs/branch-heads/5005@{#1125}
OS | macOS Version 12.4 (Build 21F79)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@jamesmudgett jamesmudgett added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jun 24, 2022
@bbondy
Copy link
Member

bbondy commented Jul 4, 2022

@onyb what do you think is the cause of this one?

@srirambv srirambv added the QA/Yes label Jul 6, 2022
@onyb
Copy link
Member

onyb commented Jul 8, 2022

It seems the blockCount parameter of eth_feeHistory no longer accepts an integer, and expects a hex-encoded string. See docs: https://ethereum.github.io/execution-apis/api-documentation

geth supports both integer and hex strings, but apparently Moonbeam does not:

curl -s https://rpc.ankr.com/moonbeam -X POST -H "Content-Type: application/json" -d '{"id":1,"jsonrpc":"2.0","method":"eth_feeHistory","params":[300, "latest", [20,50,80]]}' | jq      
{
  "jsonrpc": "2.0",
  "error": {
    "code": -32602,
    "message": "Invalid params: invalid type: integer `300`, expected a (both 0x-prefixed or not) hex string with length between (0; 64]."
  },
  "id": 1
}

Changing blockCount parameter to use 0x-prefixed hex string fixed the issue. I suggest we apply this change without making an exception for Moonbeam. @bbondy

@onyb
Copy link
Member

onyb commented Jul 8, 2022

Related geth fix here: ethereum/go-ethereum#23239, included in 1.10.7.

@bbondy
Copy link
Member

bbondy commented Jul 8, 2022

sgtm!

@kjozwiak
Copy link
Member

The above will require 1.41.96 or higher for 1.41.x verification.

@srirambv
Copy link
Contributor

Brave 1.41.96 Chromium: 103.0.5060.114 (Official Build) (64-bit)
Revision a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
OS ☑️ Linux ☑️ Windows 11 Version 21H2
(Build 22000.708)
☑️ macOS Version 12.0.1
(Build 21C52)
  • Verified steps from issue description
  • Verified able to submit a send transaction for GLMR token on Moonbeam network
  • Verified able to get a successful transaction notification
23529-Linux.mp4
23529-Windows.mp4
23529-macOS.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

8 participants
@jamesmudgett @bbondy @kjozwiak @onyb @srirambv @josheleonard @brave-builds and others