Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deleted sites from muon are not being imported to Rewards - follow up to PR 736 #2340

Closed
LaurenWags opened this issue Dec 3, 2018 · 1 comment · Fixed by brave/brave-core#1010

Comments

@LaurenWags
Copy link
Member

Description

Found while testing brave/brave-core#736

Per test plan in brave/brave-core#736, Deleted sites from muon should be imported as 'excluded' sites in Brave Rewards.

Steps to Reproduce

Follow test plan in brave/brave-core#736 or

  1. Have a muon Brave profile set up with 0.25.2 where you have Payments data (wallet, etc). Have some sites in table, delete some others.
  2. Close muon Brave.
  3. Ensure you don’t have any Brave-Browser profile for b-c Brave.
  4. Launch 0.57.12.
  5. Import only Payments data from Brave (Brave > Import Bookmarks and Settings > choose Brave (old) > only have Payments checked
  6. Navigate to 6 sites.

Actual result:

When you open the popup to view all sites, no link for restoring excluded sites. You can also try visiting a site that you know was excluded in muon. --> Watch it get added to your A-C table after specified time from settings. Alternatively, I clicked on the BAT logo and saw that the toggle for ‘Include in Auto-Contribute’ for this site was set to On.

screen shot 2018-12-03 at 3 52 46 pm

Expected result:

Deleted sites from muon Payments should be 'excluded' in Rewards.

Reproduces how often:

easily

Brave version (brave://version info)

Brave 0.57.12 Chromium: 71.0.3578.75 (Official Build) (64-bit)
Revision 06ef00b5279f93f8e0c1e73acedd49d7dcc09767-refs/branch-heads/3578@{#836}
OS Mac OS X

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

cc @bsclifton

@bsclifton
Copy link
Member

Closing as wontfix after discussion on Slack. Let's re-open if this should indeed block the release (and needs a fix)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment